encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-05 21:10:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Added detailed warning about duplicate keys

Browse Source
This commit is contained in:
Alan Braithwaite 2014-04-07 15:06:48 -07:00
parent 7d1c1b4649
commit f9dd11df72
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
rest_framework/serializers.py
View File

@ -15,6 +15,7 @@ import copy
import datetime import datetime
import inspect import inspect
import types import types
import warnings
from decimal import Decimal from decimal import Decimal
from django.core.paginator import Page from django.core.paginator import Page
from django.db import models from django.db import models
@ -298,7 +299,9 @@ class BaseSerializer(WritableField):
for name, value in list(self.fields.items()): for name, value in list(self.fields.items()):
key = self.get_field_key(name) key = self.get_field_key(name)
if key in ret: if key in ret:
raise Warning() warnings.warn("Duplicate key found in fields. This can happen if `get_field_key`"
" can return the same string for two different inputs! Ensure your keys are unique"
" after running them all through `get_field_key`", Warning, stacklevel=3)
ret[key] = name ret[key] = name
return ret return ret