encode/django-rest-framework
1
1
Fork 0
mirror of https://github.com/encode/django-rest-framework.git synced 2025-08-02 11:30:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

return 404 in DestroyModelMixin

Browse Source 
In case self.get_object() returns None we should return a 404.
This commit is contained in:
Rui Lima 2018-07-08 18:26:31 +01:00 committed by GitHub
parent 38b3d0109b
commit f9de3913ea
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rest_framework/mixins.py
View File

@ -90,6 +90,8 @@ class DestroyModelMixin(object):
""" """
def destroy(self, request, *args, **kwargs): def destroy(self, request, *args, **kwargs):
instance = self.get_object() instance = self.get_object()
if not instance:
return Response(status=status.HTTP_404_NOT_FOUND)
self.perform_destroy(instance) self.perform_destroy(instance)
return Response(status=status.HTTP_204_NO_CONTENT) return Response(status=status.HTTP_204_NO_CONTENT)