Commit Graph

8449 Commits

Author SHA1 Message Date
David Smith
cde3503a71 Fixed dropdown button 2021-04-27 18:36:49 +01:00
David Smith
d5edf0feb7 Changed left/right to start/end
Changed in beta 1. See https://getbootstrap.com/docs/5.0/migration/#utilities-2
2021-04-27 18:36:49 +01:00
David Smith
b5bf67d213 Changed hide to d-none
The hide class in bootstrap 2 added display:none.

This is done via d-none in v5 see.

https://getbootstrap.com/docs/5.0/utilities/display/#notation
2021-04-27 18:36:49 +01:00
David Smith
db81b27469 Namespaced data attributes
Changed in beta 1 see - https://getbootstrap.com/docs/5.0/migration/#javascript-2
2021-04-27 18:36:49 +01:00
David Smith
3d156f476a Bump Bootstrap to v5.0.0-beta3 2021-04-27 18:36:48 +01:00
David Smith
0d1d54de1e Used bootstrap5 bundled js
* No need to add popper.js as a separate source
2021-04-27 18:36:48 +01:00
David Smith
971bca63f7 Remove duplicate <p> tags
* render_markdown returns its content in a <p> tag, so don't need to wrap again.
2021-04-27 18:36:48 +01:00
David Smith
b0c51d8707 remove fontawesome 2021-04-27 18:36:48 +01:00
David Smith
a3d9232ea9 Docs
* Fixed sidebar collapse (links now work)
* Changed fontawsome icons to bootstrap icones
2021-04-27 18:36:48 +01:00
David Smith
ec558a484f Admin
* Updated glyphicons to Bootstrap 5 icons
2021-04-27 18:36:48 +01:00
David Smith
5a5cece5bd Inline Forms 2021-04-27 18:36:48 +01:00
David Smith
fe7a0cf3c5 Filters
* Used bootstrap v5 icon pack
2021-04-27 18:36:45 +01:00
David Smith
5577d3632e Vertical forms 2021-04-27 18:34:36 +01:00
David Smith
39c22e057d Fixed tests following horizontal form changes
* error class has changed to `invalid-feedback`
2021-04-27 18:34:35 +01:00
David Smith
fc7235e636 Horizontal forms
* checkbox are now fully custom by default in Bootstrap5 - removed previous tweaks.
* control-label --> col-form-label
* errors now need `invalid-feedback` on the text and `is-invalid` on the input
* new `form-text` class for help text
* New html layout and css classes for radio/multiple checkbox. Added work around for errors and inline (see comments in code).
2021-04-27 18:34:35 +01:00
David Smith
44c9d8f3c7 Changed form-group to mb-3
* form-group is deprecated in bootstrap 5 and is replaced by utility classes.
2021-04-27 18:34:35 +01:00
David Smith
8492841ed3 HTML/Raw data forms
* form-horizontal is no longer used. Need to use the grid.

aligned tabs right

Raw Data Form
* Use grid / rows to space form. form-group has been deprecated in favour of utility classes.

Replaced `well` class (background colour/border) with bootstrap utility classes
2021-04-27 18:34:35 +01:00
David Smith
69ba59ccb1 Pagination (numbers.html) 2021-04-27 18:34:35 +01:00
David Smith
db22809971 Page header
* BS3 had lots of top (20px) and bottom (10px) margin to push page down. Now added top margin on the div.
* Font has style has changed with bs5. But is slightly custom as font weight is over riden. Personally think it looks ok.
2021-04-27 18:34:35 +01:00
David Smith
7be17e9bae Navbar and top buttons
* navbar-expand-md to stop navbar growing when dropdown opens.
* Split dropdown doesn't work with tooltip - looks like a bs5 bug (same layout works with bs4)
* Need to check button colours
* Need to look at colour of dropdown links
2021-04-27 18:34:35 +01:00
David Smith
830f515214 Updated static files to BS-v5 & added popper.js 2021-04-27 18:34:35 +01:00
Julien Palard
a0083f7f98
FIX: Broken cite. (#7951) 2021-04-26 09:30:41 +01:00
Łukasz Skarżyński
431f7dfa3d
fix typo in packaging requirements (#7949) 2021-04-23 09:34:58 +01:00
Denis Orehovsky
8812394ed8
Add distinction between request and response serializers for OpenAPI (#7424)
* Add distinction between request and response serializers

* Add docs

* document new functions in schemas.md

* add a test case for different request vs response objects

* Correct formatting for flake8

Co-authored-by: Shaun Gosse <shaun.gosse@emburse.com>
2021-04-20 15:03:16 +01:00
Adam Johnson
010c8d4f08
Use tox-py in CI (#7925) 2021-04-16 17:59:27 +01:00
Adam Johnson
67b5093ca5
Fix pytest warnings (#7928)
* Use `--strict-markers` instead of `--strict`, as per this warning:

  ```
  /.../_pytest/config/__init__.py:1183: PytestDeprecationWarning: The --strict option is deprecated, use --strict-markers instead.
  ```

* Remove config option 'testspath' - pytest is logging a warning about this being unknown:

  ```
  /.../_pytest/config/__init__.py:1233: PytestConfigWarning: Unknown config option: testspath
  ```

  I can't find any reference to it in the pytest docs or changelog.
2021-04-16 17:47:21 +01:00
Terence Honles
a0a2c5cb37
Fix tests with mock timezone (#7911)
After django/django#13877, Django no longer checks for `hasattr(timezone, 'localize')` and instead does an inheritance check.
2021-04-16 17:27:22 +01:00
Adam Johnson
f628db383a
Fix GitHub Actions to run on 'master' branch (#7926)
The config I copied in #7903 was from a repo with the new name 'main', so tests have not been running on master since.
2021-04-16 17:23:18 +01:00
Terence Honles
1c494e3d94
Update references to Travis CI after moving to Github Actions (#7909)
x-ref: https://github.com/encode/django-rest-framework/pull/7903
2021-04-12 13:14:26 +01:00
Lalit Suthar
9bdd6125a1
fix broken article link (#7918)
Co-authored-by: lalit97 <lalit.suthar@redhuntlabs.com>
2021-04-12 11:59:58 +01:00
Adam Johnson
fd017d00f9
Move CI to GitHub Actions (#7903)
* Recreate all the jobs on GitHub Actions
* Upgrade to Ubuntu 20.04
* Upgrade base/docs/dist to Python 3.9
2021-04-06 18:34:18 +01:00
Adam Johnson
90635c138f
Update pre-commit for flake8 move (#7907)
See: https://twitter.com/codewithanthony/status/1378746934928699396
2021-04-06 17:49:17 +01:00
Adam Johnson
37ef62b0e6
Remove link to third party cookiecutter template (#7902)
The template has not been maintained for six years, so it's out of date on versions and various "best practices" (e.g. pre-commit). I also think any template should be documented on its own repo rather than here, especially if it's not an official maintained project.
2021-04-05 18:18:35 +01:00
Adam Johnson
aa12a5f967
Lint with pre-commit (#7900)
Following [my comment here](https://github.com/encode/django-rest-framework/pull/7589#issuecomment-813301322) and [Django's own move to pre-commit](https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/coding-style/#pre-commit-checks).

* Add pre-commit config file to run flake8 and isort.
* Add extra "common sense" hooks.
* Run pre-commit on GitHub actions using the [official action](https://github.com/pre-commit/action/). This is a good way to get up-and-running but it would be better if we activated [pre-commit.ci](https://pre-commit.ci/), which is faster and will auto-update the hooks for us going forwards.
* Remove `runtests.py` code for running linting tools.
* Remove `runtests.py --fast` flag, since that would now just run `pytest -q`, which can be done with `runtests.py -q` instead.
* Remove tox configuration and requirements files for linting.
* Update the contributing guide to mention setting up pre-commit.
2021-04-05 12:08:52 +01:00
Adam Johnson
846fe70cff
De-duplicate contributing guide (#7901)
The contributing guide from `docs/community/contributing.md` was copy-pasted to `CONTRIBUTING.md` and the two have drifted apart over time. The docs page seems to have been updated a bit more so let's leave only that version.
2021-04-05 11:12:28 +01:00
David Smith
d82519bf8a
Updated dependencies (#7589) 2021-04-05 10:28:03 +01:00
dependabot[bot]
78da1a824f
Bump pygments from 2.4.2 to 2.7.4 in /requirements (#7886)
Bumps [pygments](https://github.com/pygments/pygments) from 2.4.2 to 2.7.4.
- [Release notes](https://github.com/pygments/pygments/releases)
- [Changelog](https://github.com/pygments/pygments/blob/master/CHANGES)
- [Commits](https://github.com/pygments/pygments/compare/2.4.2...2.7.4)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2021-04-01 16:52:19 +01:00
Tom Christie
406e6a2f35
Update MANIFEST.in (#7893) 2021-04-01 14:15:53 +01:00
David Smith
96885dd9a7
Fixed markdown test (#7892)
The pygments rendering of invalid json changed in  pygments>=2.7.3
2021-04-01 09:49:47 +01:00
Tom Christie
0323d6f895
Linting fixes (#7874)
* Fixed code quality issues

- Added '.deepsource.toml' file for continuous analysis on bug risk

- Remove `return` from `__init__()` method

- Remove duplicate dictionary key(s)

- Use `max` built-in to get the maximum of two values

- Remove redundant `None` default

- Remove unnecessary comprehension

Signed-off-by: ankitdobhal <dobhal.ankit@protonmail.com>

* Delete .deepsource.toml

* Delete test_fields.py

* Reintroduce file from accidental deletion

Co-authored-by: ankitdobhal <dobhal.ankit@protonmail.com>
2021-03-26 12:27:10 +00:00
Tom Christie
f83620dcc9
Version 3.12.4 (#7873)
* Version 3.12.4

* Tweak release notes
2021-03-26 09:27:01 +00:00
Tom Christie
72c155d8f4
Revert "pick deque instead of list (#7849)" (#7872)
This reverts commit ebcb8d5310.
2021-03-26 09:17:47 +00:00
Tom Christie
dffa612134
Fix release notes typo 2021-03-25 12:30:45 +00:00
Tom Christie
83ad265e13
Version 3.12.3 (#7866) 2021-03-25 12:23:23 +00:00
Jack
ebcb8d5310
pick deque instead of list (#7849)
Co-authored-by: Jack Zhang <jack.zhang@aspiraconnect.com>
2021-03-25 10:47:44 +00:00
Joe Michelini
71e6c30034
update SerializerMethodField example in docs (#7858)
* update SerializerMethodField example

* fix formatting
2021-03-22 12:08:19 +00:00
Mohammad Ashraful Islam
7e3dd9cd1b
Added fast-drf as a thirdparty package for making API development faster. (#7857) 2021-03-22 12:07:48 +00:00
Hasan Talha Yazıcı
0cddf097ca
Fix typo in docs (#7853) 2021-03-21 09:53:09 +00:00
Anton Zaslavskiy
b25ac6c5e3
Don't hit db to access user_id in TokenProxy (#7852) 2021-03-19 11:46:09 +00:00
Aristotelis Mikropoulos
67ebdd32cd
Reject PrimaryKeyRelatedField bool lookup values (#7597)
* Reject PrimaryKeyRelatedField bool lookup values

* Test PrimaryKeyRelatedField bool lookup rejection

* Fix indentation in test
2021-03-17 13:28:38 +00:00