mirror of
				https://github.com/encode/django-rest-framework.git
				synced 2025-10-31 16:07:38 +03:00 
			
		
		
		
	* Fix #9250: Prevent token overwrite and improve security - Fix key collision issue that could overwrite existing tokens - Use force_insert=True only for new token instances - Replace os.urandom with secrets.token_hex for better security - Add comprehensive test suite to verify fix and backward compatibility - Ensure existing tokens can still be updated without breaking changes * Fix code style: remove trailing whitespace and unused imports * Fix #9250: Prevent token overwrite with minimal changes - Add force_insert=True to Token.save() for new objects to prevent overwriting existing tokens - Revert generate_key method to original implementation (os.urandom + binascii) - Update tests to work with original setUp() approach - Remove verbose comments and unrelated changes per reviewer feedback * Fix flake8 violations: remove extra blank lines and trailing whitespace * Update tests/test_authtoken.py Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com> * Update tests/test_authtoken.py Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com> * Update tests/test_authtoken.py Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com> * Fix token key regeneration behavior and add test * Update tests/test_authtoken.py Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com> --------- Co-authored-by: Bruno Alla <browniebroke@users.noreply.github.com>
		
			
				
	
	
		
			136 lines
		
	
	
		
			5.4 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			136 lines
		
	
	
		
			5.4 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
| import importlib
 | |
| from io import StringIO
 | |
| 
 | |
| import pytest
 | |
| from django.contrib.admin import site
 | |
| from django.contrib.auth.models import User
 | |
| from django.core.management import CommandError, call_command
 | |
| from django.db import IntegrityError
 | |
| from django.test import TestCase, modify_settings
 | |
| 
 | |
| from rest_framework.authtoken.admin import TokenAdmin
 | |
| from rest_framework.authtoken.management.commands.drf_create_token import \
 | |
|     Command as AuthTokenCommand
 | |
| from rest_framework.authtoken.models import Token
 | |
| from rest_framework.authtoken.serializers import AuthTokenSerializer
 | |
| from rest_framework.exceptions import ValidationError
 | |
| 
 | |
| 
 | |
| class AuthTokenTests(TestCase):
 | |
| 
 | |
|     def setUp(self):
 | |
|         self.site = site
 | |
|         self.user = User.objects.create_user(username='test_user')
 | |
|         self.token = Token.objects.create(key='test token', user=self.user)
 | |
| 
 | |
|     def test_authtoken_can_be_imported_when_not_included_in_installed_apps(self):
 | |
|         import rest_framework.authtoken.models
 | |
|         with modify_settings(INSTALLED_APPS={'remove': 'rest_framework.authtoken'}):
 | |
|             importlib.reload(rest_framework.authtoken.models)
 | |
|         # Set the proxy and abstract properties back to the version,
 | |
|         # where authtoken is among INSTALLED_APPS.
 | |
|         importlib.reload(rest_framework.authtoken.models)
 | |
| 
 | |
|     def test_model_admin_displayed_fields(self):
 | |
|         mock_request = object()
 | |
|         token_admin = TokenAdmin(self.token, self.site)
 | |
|         assert token_admin.get_fields(mock_request) == ('user',)
 | |
| 
 | |
|     def test_token_string_representation(self):
 | |
|         assert str(self.token) == 'test token'
 | |
| 
 | |
|     def test_validate_raise_error_if_no_credentials_provided(self):
 | |
|         with pytest.raises(ValidationError):
 | |
|             AuthTokenSerializer().validate({})
 | |
| 
 | |
|     def test_whitespace_in_password(self):
 | |
|         data = {'username': self.user.username, 'password': 'test pass '}
 | |
|         self.user.set_password(data['password'])
 | |
|         self.user.save()
 | |
|         assert AuthTokenSerializer(data=data).is_valid()
 | |
| 
 | |
|     def test_token_creation_collision_raises_integrity_error(self):
 | |
|         user2 = User.objects.create_user('user2', 'user2@example.com', 'p')
 | |
|         existing_token = Token.objects.create(user=user2)
 | |
| 
 | |
|         # Try to create another token with the same key
 | |
|         with self.assertRaises(IntegrityError):
 | |
|             Token.objects.create(key=existing_token.key, user=self.user)
 | |
| 
 | |
|     def test_key_generated_on_save_when_cleared(self):
 | |
|         # Create a new user for this test to avoid conflicts with setUp token
 | |
|         user2 = User.objects.create_user('test_user2', 'test2@example.com', 'password')
 | |
| 
 | |
|         # Create a token without a key - it should generate one automatically
 | |
|         token = Token(user=user2)
 | |
|         token.key = ""  # Explicitly clear the key
 | |
|         token.save()
 | |
| 
 | |
|         # Verify the key was generated
 | |
|         self.assertEqual(len(token.key), 40)
 | |
|         self.assertEqual(token.user, user2)
 | |
| 
 | |
|     def test_clearing_key_on_existing_token_raises_integrity_error(self):
 | |
|         """Test that clearing the key on an existing token raises IntegrityError."""
 | |
|         user = User.objects.create_user('test_user3', 'test3@example.com', 'password')
 | |
|         token = Token.objects.create(user=user)
 | |
|         token.key = ""
 | |
| 
 | |
|         # This should raise IntegrityError because:
 | |
|         # 1. We're trying to update a record with an empty primary key
 | |
|         # 2. The OneToOneField constraint would be violated
 | |
|         with self.assertRaises(Exception):  # Could be IntegrityError or DatabaseError
 | |
|             token.save()
 | |
| 
 | |
|     def test_saving_existing_token_without_changes_does_not_alter_key(self):
 | |
|         original_key = self.token.key
 | |
| 
 | |
|         self.token.save()
 | |
|         self.assertEqual(self.token.key, original_key)
 | |
| 
 | |
| 
 | |
| class AuthTokenCommandTests(TestCase):
 | |
| 
 | |
|     def setUp(self):
 | |
|         self.site = site
 | |
|         self.user = User.objects.create_user(username='test_user')
 | |
| 
 | |
|     def test_command_create_user_token(self):
 | |
|         token = AuthTokenCommand().create_user_token(self.user.username, False)
 | |
|         assert token is not None
 | |
|         token_saved = Token.objects.first()
 | |
|         assert token.key == token_saved.key
 | |
| 
 | |
|     def test_command_create_user_token_invalid_user(self):
 | |
|         with pytest.raises(User.DoesNotExist):
 | |
|             AuthTokenCommand().create_user_token('not_existing_user', False)
 | |
| 
 | |
|     def test_command_reset_user_token(self):
 | |
|         AuthTokenCommand().create_user_token(self.user.username, False)
 | |
|         first_token_key = Token.objects.first().key
 | |
|         AuthTokenCommand().create_user_token(self.user.username, True)
 | |
|         second_token_key = Token.objects.first().key
 | |
| 
 | |
|         assert first_token_key != second_token_key
 | |
| 
 | |
|     def test_command_do_not_reset_user_token(self):
 | |
|         AuthTokenCommand().create_user_token(self.user.username, False)
 | |
|         first_token_key = Token.objects.first().key
 | |
|         AuthTokenCommand().create_user_token(self.user.username, False)
 | |
|         second_token_key = Token.objects.first().key
 | |
| 
 | |
|         assert first_token_key == second_token_key
 | |
| 
 | |
|     def test_command_raising_error_for_invalid_user(self):
 | |
|         out = StringIO()
 | |
|         with pytest.raises(CommandError):
 | |
|             call_command('drf_create_token', 'not_existing_user', stdout=out)
 | |
| 
 | |
|     def test_command_output(self):
 | |
|         out = StringIO()
 | |
|         call_command('drf_create_token', self.user.username, stdout=out)
 | |
|         token_saved = Token.objects.first()
 | |
|         self.assertIn('Generated token', out.getvalue())
 | |
|         self.assertIn(self.user.username, out.getvalue())
 | |
|         self.assertIn(token_saved.key, out.getvalue())
 |