ets-labs/python-dependency-injector
1
1
Fork 0
mirror of https://github.com/ets-labs/python-dependency-injector.git synced 2024-11-22 09:36:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix a bug in the `Configuration provider to correctly handle overriding by None`.

Browse Source
This commit is contained in:
Roman Mogylatov 2021-01-15 06:44:24 -05:00
parent 1cbd3a0215
commit 1c87a9973d
3 changed files with 3176 additions and 3131 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6298
src/dependency_injector/providers.c
View File

File diff suppressed because it is too large Load Diff

2
src/dependency_injector/providers.pyx
View File

@ -1507,6 +1507,8 @@ cdef class Configuration(Object):
:return: Overriding context. :return: Overriding context.
:rtype: :py:class:`OverridingContext` :rtype: :py:class:`OverridingContext`
""" """
if provider is None:
provider = {}
context = super().override(provider) context = super().override(provider)
self.reset_cache() self.reset_cache()
return context return context

7
tests/unit/providers/test_configuration_py2_py3.py
View File

@ -185,6 +185,13 @@ class ConfigTests(unittest.TestCase):
with self.assertRaises(AttributeError): with self.assertRaises(AttributeError):
a.__name__ a.__name__
def test_missing_key(self):
# See: https://github.com/ets-labs/python-dependency-injector/issues/358
self.config.override(None)
value = self.config.key()
self.assertIsNone(value)
def test_deepcopy(self): def test_deepcopy(self):
provider = providers.Configuration('config') provider = providers.Configuration('config')
provider_copy = providers.deepcopy(provider) provider_copy = providers.deepcopy(provider)