Refactor unnecessary else / elif when if block has a return statement

This commit is contained in:
shubhendra 2021-02-25 12:56:04 +05:30
parent d3720bd6dd
commit 34db0770c3
No known key found for this signature in database
GPG Key ID: 9AFEF5C98D542137
2 changed files with 17 additions and 6 deletions

12
.deepsource.toml Normal file
View File

@ -0,0 +1,12 @@
version = 1
test_patterns = ["tests/**/test_*.py"]
exclude_patterns = ["docs/**"]
[[analyzers]]
name = "python"
enabled = true
[analyzers.meta]
runtime_version = "3.x.x"

View File

@ -111,21 +111,20 @@ class ProvidersMap:
) -> Optional[providers.Provider]: ) -> Optional[providers.Provider]:
if isinstance(provider, providers.Delegate): if isinstance(provider, providers.Delegate):
return self._resolve_delegate(provider) return self._resolve_delegate(provider)
elif isinstance(provider, ( if isinstance(provider, (
providers.ProvidedInstance, providers.ProvidedInstance,
providers.AttributeGetter, providers.AttributeGetter,
providers.ItemGetter, providers.ItemGetter,
providers.MethodCaller, providers.MethodCaller,
)): )):
return self._resolve_provided_instance(provider) return self._resolve_provided_instance(provider)
elif isinstance(provider, providers.ConfigurationOption): if isinstance(provider, providers.ConfigurationOption):
return self._resolve_config_option(provider) return self._resolve_config_option(provider)
elif isinstance(provider, providers.TypedConfigurationOption): if isinstance(provider, providers.TypedConfigurationOption):
return self._resolve_config_option(provider.option, as_=provider.provides) return self._resolve_config_option(provider.option, as_=provider.provides)
elif isinstance(provider, str): if isinstance(provider, str):
return self._resolve_string_id(provider, modifier) return self._resolve_string_id(provider, modifier)
else: return self._resolve_provider(provider)
return self._resolve_provider(provider)
def _resolve_string_id( def _resolve_string_id(
self, self,