From 3cc54462bd4e322d504d02af0f21f39e274815ce Mon Sep 17 00:00:00 2001 From: Roman Mogylatov Date: Mon, 20 Dec 2021 19:15:19 +0200 Subject: [PATCH] Add tests for an empty environment variable --- tests/unit/providers/configuration/conftest.py | 2 ++ .../providers/configuration/test_from_env_py2_py3.py | 12 ++++++++++++ 2 files changed, 14 insertions(+) diff --git a/tests/unit/providers/configuration/conftest.py b/tests/unit/providers/configuration/conftest.py index 9f473790..ee99fd3a 100644 --- a/tests/unit/providers/configuration/conftest.py +++ b/tests/unit/providers/configuration/conftest.py @@ -106,9 +106,11 @@ def environment_variables(): os.environ["CONFIG_TEST_ENV"] = "test-value" os.environ["CONFIG_TEST_PATH"] = "test-path" os.environ["DEFINED"] = "defined" + os.environ["EMPTY"] = "" os.environ["CONFIG_INT"] = "42" yield os.environ.pop("CONFIG_TEST_ENV", None) os.environ.pop("CONFIG_TEST_PATH", None) os.environ.pop("DEFINED", None) + os.environ.pop("EMPTY", None) os.environ.pop("CONFIG_INT", None) diff --git a/tests/unit/providers/configuration/test_from_env_py2_py3.py b/tests/unit/providers/configuration/test_from_env_py2_py3.py index 24c4e914..a65d5c95 100644 --- a/tests/unit/providers/configuration/test_from_env_py2_py3.py +++ b/tests/unit/providers/configuration/test_from_env_py2_py3.py @@ -49,6 +49,12 @@ def test_as__undefined_required(config): assert config() == {} +def test_as__defined_empty(config): + with raises(ValueError): + config.from_env("EMPTY", as_=int) + assert config() == {} + + def test_option_as_(config): config.option.from_env("CONFIG_INT", as_=int) assert config.option() == 42 @@ -67,6 +73,12 @@ def test_option_as__undefined_required(config): assert config.option() is None +def test_option_as__defined_empty(config): + with raises(ValueError): + config.option.from_env("EMPTY", as_=int) + assert config.option() is None + + @mark.parametrize("config_type", ["strict"]) def test_undefined_in_strict_mode(config): with raises(ValueError):