From 48a4275940a7c0529ef5dfc7ccd0a722232dc306 Mon Sep 17 00:00:00 2001 From: Roman Mogylatov Date: Tue, 11 Aug 2020 22:18:58 -0400 Subject: [PATCH] Rename name to title --- examples/miniapps/movie-lister/README.rst | 4 ++-- examples/miniapps/movie-lister/data/fixtures.py | 2 +- examples/miniapps/movie-lister/movies/entities.py | 8 ++++---- examples/miniapps/movie-lister/movies/finders.py | 2 +- examples/miniapps/movie-lister/movies/tests.py | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/examples/miniapps/movie-lister/README.rst b/examples/miniapps/movie-lister/README.rst index 0f776e48..9b342b52 100644 --- a/examples/miniapps/movie-lister/README.rst +++ b/examples/miniapps/movie-lister/README.rst @@ -39,8 +39,8 @@ The output should be something like: .. code-block:: bash - Francis Lawrence movies: [Movie(name='The Hunger Games: Mockingjay - Part 2', year=2015, director='Francis Lawrence')] - 2016 movies: [Movie(name='Rogue One: A Star Wars Story', year=2016, director='Gareth Edwards'), Movie(name='The Jungle Book', year=2016, director='Jon Favreau')] + Francis Lawrence movies: [Movie(title='The Hunger Games: Mockingjay - Part 2', year=2015, director='Francis Lawrence')] + 2016 movies: [Movie(title='Rogue One: A Star Wars Story', year=2016, director='Gareth Edwards'), Movie(title='The Jungle Book', year=2016, director='Jon Favreau')] Test ---- diff --git a/examples/miniapps/movie-lister/data/fixtures.py b/examples/miniapps/movie-lister/data/fixtures.py index ee9241d7..28a836d6 100644 --- a/examples/miniapps/movie-lister/data/fixtures.py +++ b/examples/miniapps/movie-lister/data/fixtures.py @@ -28,7 +28,7 @@ def create_sqlite(movies_data, path): with sqlite3.connect(path) as db: db.execute( 'CREATE TABLE IF NOT EXISTS movies ' - '(name text, year int, director text)' + '(title text, year int, director text)' ) db.execute('DELETE FROM movies') db.executemany('INSERT INTO movies VALUES (?,?,?)', movies_data) diff --git a/examples/miniapps/movie-lister/movies/entities.py b/examples/miniapps/movie-lister/movies/entities.py index 0a51cae6..8f855d58 100644 --- a/examples/miniapps/movie-lister/movies/entities.py +++ b/examples/miniapps/movie-lister/movies/entities.py @@ -3,15 +3,15 @@ class Movie: - def __init__(self, name: str, year: int, director: str): - self.name = str(name) + def __init__(self, title: str, year: int, director: str): + self.title = str(title) self.year = int(year) self.director = str(director) def __repr__(self): - return '{0}(name={1}, year={2}, director={3})'.format( + return '{0}(title={1}, year={2}, director={3})'.format( self.__class__.__name__, - repr(self.name), + repr(self.title), repr(self.year), repr(self.director), ) diff --git a/examples/miniapps/movie-lister/movies/finders.py b/examples/miniapps/movie-lister/movies/finders.py index 0df196c3..3485d8c3 100644 --- a/examples/miniapps/movie-lister/movies/finders.py +++ b/examples/miniapps/movie-lister/movies/finders.py @@ -46,5 +46,5 @@ class SqliteMovieFinder(MovieFinder): def find_all(self) -> List[Movie]: with self._database as db: - rows = db.execute('SELECT name, year, director FROM movies') + rows = db.execute('SELECT title, year, director FROM movies') return [self._movie_factory(*row) for row in rows] diff --git a/examples/miniapps/movie-lister/movies/tests.py b/examples/miniapps/movie-lister/movies/tests.py index a992bf92..f6bfe81f 100644 --- a/examples/miniapps/movie-lister/movies/tests.py +++ b/examples/miniapps/movie-lister/movies/tests.py @@ -37,7 +37,7 @@ def test_movies_directed_by(container): movies = lister.movies_directed_by('Jon Favreau') assert len(movies) == 1 - assert movies[0].name == 'The Jungle Book' + assert movies[0].title == 'The Jungle Book' def test_movies_released_in(container): @@ -52,4 +52,4 @@ def test_movies_released_in(container): movies = lister.movies_released_in(2015) assert len(movies) == 1 - assert movies[0].name == 'The 33' + assert movies[0].title == 'The 33'