From 51c7db771d22eed1a6ff0a3ae1bdc5715f2ed516 Mon Sep 17 00:00:00 2001 From: ZipFile Date: Sun, 1 Jun 2025 17:35:32 +0000 Subject: [PATCH] Fix csv newline handling in movie-lister example --- examples/miniapps/movie-lister/data/fixtures.py | 5 ++--- examples/miniapps/movie-lister/movies/finders.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/miniapps/movie-lister/data/fixtures.py b/examples/miniapps/movie-lister/data/fixtures.py index aa1691d5..0153e0cf 100644 --- a/examples/miniapps/movie-lister/data/fixtures.py +++ b/examples/miniapps/movie-lister/data/fixtures.py @@ -18,10 +18,9 @@ SQLITE_FILE = DIR / "movies.db" def create_csv(movies_data, path): - with open(path, "w") as opened_file: + with open(path, "w", newline="") as opened_file: writer = csv.writer(opened_file) - for row in movies_data: - writer.writerow(row) + writer.writerows(movies_data) def create_sqlite(movies_data, path): diff --git a/examples/miniapps/movie-lister/movies/finders.py b/examples/miniapps/movie-lister/movies/finders.py index 52b8ed55..5e6d2c9c 100644 --- a/examples/miniapps/movie-lister/movies/finders.py +++ b/examples/miniapps/movie-lister/movies/finders.py @@ -29,7 +29,7 @@ class CsvMovieFinder(MovieFinder): super().__init__(movie_factory) def find_all(self) -> List[Movie]: - with open(self._csv_file_path) as csv_file: + with open(self._csv_file_path, newline="") as csv_file: csv_reader = csv.reader(csv_file, delimiter=self._delimiter) return [self._movie_factory(*row) for row in csv_reader]