From 731af81a7737084a0dc8152c0b72796eade9a54c Mon Sep 17 00:00:00 2001 From: Leonardus Chen Date: Sat, 15 Nov 2025 15:43:59 +0700 Subject: [PATCH] Remove TODOs to adjust for fixed stubs --- tests/typing/aggregate.py | 3 +-- tests/typing/callable.py | 7 ++----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/typing/aggregate.py b/tests/typing/aggregate.py index 3beff893..6518257a 100644 --- a/tests/typing/aggregate.py +++ b/tests/typing/aggregate.py @@ -27,8 +27,7 @@ provider_set_non_string_1 = provider1_set_non_string_keys.providers[Cat] assert_type(provider_set_non_string_1, providers.Provider[str]) -# TODO: Change providers.Aggregate to accept Mapping? Then remove explicit typing here -provider1_new_non_string_keys = providers.Aggregate[str]( +provider1_new_non_string_keys = providers.Aggregate( {Cat: providers.Object("str")}, ) factory_new_non_string_1 = provider1_new_non_string_keys.providers[Cat] diff --git a/tests/typing/callable.py b/tests/typing/callable.py index 81312b20..3ee02ac4 100644 --- a/tests/typing/callable.py +++ b/tests/typing/callable.py @@ -33,8 +33,7 @@ provider4 = providers.Callable(Animal) args4 = provider4.args kwargs4 = provider4.kwargs assert_type(args4, Tuple[Any]) -# TODO: Change Callable.kwargs to Dict[str, Any]? Then adjust test back to Dict[str, Any] -assert_type(kwargs4, Dict[Any, Any]) +assert_type(kwargs4, Dict[str, Any]) # Test 5: to check the provided instance interface provider5 = providers.Callable(Animal) @@ -42,7 +41,6 @@ provided_val5 = provider5.provided() attr_getter5 = provider5.provided.attr item_getter5 = provider5.provided["item"] method_caller5 = provider5.provided.method.call(123, arg=324) -# TODO: Remove explicit typing of Provider.provided return type assert_type(provided_val5, Any) assert_type(attr_getter5, providers.AttributeGetter) assert_type(item_getter5, providers.ItemGetter) @@ -84,6 +82,5 @@ assert_type(provides11, Optional[Callable[..., Animal]]) # Test 12: to check string imports -# TODO: Use T_Any as Callable typevar? Then remove type-ignore -provider12 = providers.Callable("builtins.dict") # type: ignore[var-annotated] +provider12 = providers.Callable("builtins.dict") provider12.set_provides("builtins.dict")