ets-labs/python-dependency-injector
1
1
Fork 0
mirror of https://github.com/ets-labs/python-dependency-injector.git synced 2025-06-19 04:53:14 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix race in ThreadSafeSingleton (#322)

Browse Source
This commit is contained in:
Dmitry Rassoshenko 2020-11-10 22:57:10 +03:00 committed by GitHub
parent 4120afd1c3
commit fb0d99c1c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/dependency_injector/providers.pyx
View File

@ -2178,15 +2178,19 @@ cdef class ThreadSafeSingleton(BaseSingleton):
:rtype: None :rtype: None
""" """
self.__storage = None with self.__storage_lock:
self.__storage = None
cpdef object _provide(self, tuple args, dict kwargs): cpdef object _provide(self, tuple args, dict kwargs):
"""Return single instance.""" """Return single instance."""
with self.__storage_lock: storage = self.__storage
if self.__storage is None: if storage is None:
self.__storage = __factory_call(self.__instantiator, with self.__storage_lock:
args, kwargs) if self.__storage is None:
return self.__storage self.__storage = __factory_call(self.__instantiator,
args, kwargs)
storage = self.__storage
return storage
cdef class DelegatedThreadSafeSingleton(ThreadSafeSingleton): cdef class DelegatedThreadSafeSingleton(ThreadSafeSingleton):