ets-labs/python-dependency-injector
1
1
Fork 0
mirror of https://github.com/ets-labs/python-dependency-injector.git synced 2025-07-14 01:52:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix a typing issue in an example

Browse Source 
`ApiClient` expects timeout to be an integer (based on a type hint), but `os.getenv` returns a string when `TIMEOUT` is set.
This commit is contained in:
Illia Volochii 2022-04-09 16:20:40 +03:00
parent 80cc30523b
commit fcec83779d
No known key found for this signature in database
GPG Key ID: 9BC2D949988CE605
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
docs/introduction/di_in_python.rst
View File

@ -68,7 +68,7 @@ Before:
def __init__(self): def __init__(self):
self.api_key = os.getenv("API_KEY") # <-- dependency self.api_key = os.getenv("API_KEY") # <-- dependency
self.timeout = os.getenv("TIMEOUT") # <-- dependency self.timeout = int(os.getenv("TIMEOUT")) # <-- dependency
class Service: class Service:
@ -114,7 +114,7 @@ After:
service=Service( service=Service(
api_client=ApiClient( api_client=ApiClient(
api_key=os.getenv("API_KEY"), api_key=os.getenv("API_KEY"),
timeout=os.getenv("TIMEOUT"), timeout=int(os.getenv("TIMEOUT")),
), ),
), ),
) )
@ -137,7 +137,7 @@ Now you need to assemble and inject the objects like this:
service=Service( service=Service(
api_client=ApiClient( api_client=ApiClient(
api_key=os.getenv("API_KEY"), api_key=os.getenv("API_KEY"),
timeout=os.getenv("TIMEOUT"), timeout=int(os.getenv("TIMEOUT")),
), ),
), ),
) )