2016-10-28 18:42:00 +03:00
|
|
|
# cython: infer_types=True
|
2018-03-27 20:23:02 +03:00
|
|
|
# cython: profile=True
|
2015-10-08 18:00:45 +03:00
|
|
|
from __future__ import unicode_literals
|
2019-02-07 11:42:25 +03:00
|
|
|
|
2015-08-05 02:05:54 +03:00
|
|
|
from libcpp.vector cimport vector
|
2019-02-07 11:42:25 +03:00
|
|
|
from libc.stdint cimport int32_t
|
2018-03-27 20:23:02 +03:00
|
|
|
from cymem.cymem cimport Pool
|
2015-10-08 18:00:45 +03:00
|
|
|
from murmurhash.mrmr cimport hash64
|
2018-03-27 20:23:02 +03:00
|
|
|
|
2019-02-07 11:42:25 +03:00
|
|
|
import re
|
|
|
|
import srsly
|
2018-03-27 20:23:02 +03:00
|
|
|
|
2019-02-07 11:42:25 +03:00
|
|
|
from ..typedefs cimport attr_t
|
|
|
|
from ..structs cimport TokenC
|
|
|
|
from ..vocab cimport Vocab
|
|
|
|
from ..tokens.doc cimport Doc, get_token_attr
|
|
|
|
from ..tokens.token cimport Token
|
2019-08-21 21:52:36 +03:00
|
|
|
from ..attrs cimport ID, attr_id_t, NULL_ATTR, ORTH, POS, TAG, DEP, LEMMA
|
2018-03-27 20:23:02 +03:00
|
|
|
|
2019-02-12 17:47:26 +03:00
|
|
|
from ._schemas import TOKEN_PATTERN_SCHEMA
|
|
|
|
from ..util import get_json_validator, validate_json
|
2019-03-15 18:38:44 +03:00
|
|
|
from ..errors import Errors, MatchPatternError, Warnings, deprecation_warning
|
2019-02-07 11:42:25 +03:00
|
|
|
from ..strings import get_string_id
|
|
|
|
from ..attrs import IDS
|
2018-03-27 20:23:02 +03:00
|
|
|
|
|
|
|
|
2019-03-08 13:42:26 +03:00
|
|
|
DEF PADDING = 5
|
|
|
|
|
|
|
|
|
|
|
|
cdef class Matcher:
|
|
|
|
"""Match sequences of tokens, based on pattern rules.
|
|
|
|
|
|
|
|
DOCS: https://spacy.io/api/matcher
|
|
|
|
USAGE: https://spacy.io/usage/rule-based-matching
|
|
|
|
"""
|
|
|
|
|
|
|
|
def __init__(self, vocab, validate=False):
|
|
|
|
"""Create the Matcher.
|
|
|
|
|
|
|
|
vocab (Vocab): The vocabulary object, which must be shared with the
|
|
|
|
documents the matcher will operate on.
|
|
|
|
RETURNS (Matcher): The newly constructed object.
|
|
|
|
"""
|
|
|
|
self._extra_predicates = []
|
|
|
|
self._patterns = {}
|
|
|
|
self._callbacks = {}
|
|
|
|
self._extensions = {}
|
2019-08-21 21:52:36 +03:00
|
|
|
self._seen_attrs = set()
|
2019-03-08 13:42:26 +03:00
|
|
|
self.vocab = vocab
|
|
|
|
self.mem = Pool()
|
2019-05-30 15:34:58 +03:00
|
|
|
if validate:
|
|
|
|
self.validator = get_json_validator(TOKEN_PATTERN_SCHEMA)
|
|
|
|
else:
|
|
|
|
self.validator = None
|
2019-03-08 13:42:26 +03:00
|
|
|
|
|
|
|
def __reduce__(self):
|
|
|
|
data = (self.vocab, self._patterns, self._callbacks)
|
|
|
|
return (unpickle_matcher, data, None, None)
|
|
|
|
|
|
|
|
def __len__(self):
|
|
|
|
"""Get the number of rules added to the matcher. Note that this only
|
|
|
|
returns the number of rules (identical with the number of IDs), not the
|
|
|
|
number of individual patterns.
|
|
|
|
|
|
|
|
RETURNS (int): The number of rules.
|
|
|
|
"""
|
|
|
|
return len(self._patterns)
|
|
|
|
|
|
|
|
def __contains__(self, key):
|
|
|
|
"""Check whether the matcher contains rules for a match ID.
|
|
|
|
|
|
|
|
key (unicode): The match ID.
|
|
|
|
RETURNS (bool): Whether the matcher contains rules for this match ID.
|
|
|
|
"""
|
|
|
|
return self._normalize_key(key) in self._patterns
|
|
|
|
|
|
|
|
def add(self, key, on_match, *patterns):
|
|
|
|
"""Add a match-rule to the matcher. A match-rule consists of: an ID
|
|
|
|
key, an on_match callback, and one or more patterns.
|
|
|
|
|
|
|
|
If the key exists, the patterns are appended to the previous ones, and
|
|
|
|
the previous on_match callback is replaced. The `on_match` callback
|
|
|
|
will receive the arguments `(matcher, doc, i, matches)`. You can also
|
|
|
|
set `on_match` to `None` to not perform any actions.
|
|
|
|
|
|
|
|
A pattern consists of one or more `token_specs`, where a `token_spec`
|
|
|
|
is a dictionary mapping attribute IDs to values, and optionally a
|
|
|
|
quantifier operator under the key "op". The available quantifiers are:
|
|
|
|
|
|
|
|
'!': Negate the pattern, by requiring it to match exactly 0 times.
|
|
|
|
'?': Make the pattern optional, by allowing it to match 0 or 1 times.
|
|
|
|
'+': Require the pattern to match 1 or more times.
|
|
|
|
'*': Allow the pattern to zero or more times.
|
|
|
|
|
|
|
|
The + and * operators are usually interpretted "greedily", i.e. longer
|
|
|
|
matches are returned where possible. However, if you specify two '+'
|
|
|
|
and '*' patterns in a row and their matches overlap, the first
|
|
|
|
operator will behave non-greedily. This quirk in the semantics makes
|
|
|
|
the matcher more efficient, by avoiding the need for back-tracking.
|
|
|
|
|
|
|
|
key (unicode): The match ID.
|
|
|
|
on_match (callable): Callback executed on match.
|
|
|
|
*patterns (list): List of token descriptions.
|
|
|
|
"""
|
|
|
|
errors = {}
|
2019-09-25 00:06:24 +03:00
|
|
|
if on_match is not None and not hasattr(on_match, "__call__"):
|
|
|
|
raise ValueError(Errors.E171.format(arg_type=type(on_match)))
|
2019-03-08 13:42:26 +03:00
|
|
|
for i, pattern in enumerate(patterns):
|
|
|
|
if len(pattern) == 0:
|
|
|
|
raise ValueError(Errors.E012.format(key=key))
|
|
|
|
if self.validator:
|
|
|
|
errors[i] = validate_json(pattern, self.validator)
|
2019-04-09 13:50:43 +03:00
|
|
|
if any(err for err in errors.values()):
|
2019-03-08 13:42:26 +03:00
|
|
|
raise MatchPatternError(key, errors)
|
|
|
|
key = self._normalize_key(key)
|
|
|
|
for pattern in patterns:
|
2019-08-21 15:00:37 +03:00
|
|
|
try:
|
|
|
|
specs = _preprocess_pattern(pattern, self.vocab.strings,
|
|
|
|
self._extensions, self._extra_predicates)
|
|
|
|
self.patterns.push_back(init_pattern(self.mem, key, specs))
|
2019-08-21 21:52:36 +03:00
|
|
|
for spec in specs:
|
|
|
|
for attr, _ in spec[1]:
|
|
|
|
self._seen_attrs.add(attr)
|
2019-08-21 15:00:37 +03:00
|
|
|
except OverflowError, AttributeError:
|
|
|
|
raise ValueError(Errors.E154.format())
|
2019-03-08 13:42:26 +03:00
|
|
|
self._patterns.setdefault(key, [])
|
|
|
|
self._callbacks[key] = on_match
|
|
|
|
self._patterns[key].extend(patterns)
|
|
|
|
|
|
|
|
def remove(self, key):
|
|
|
|
"""Remove a rule from the matcher. A KeyError is raised if the key does
|
|
|
|
not exist.
|
|
|
|
|
|
|
|
key (unicode): The ID of the match rule.
|
|
|
|
"""
|
|
|
|
key = self._normalize_key(key)
|
|
|
|
self._patterns.pop(key)
|
|
|
|
self._callbacks.pop(key)
|
|
|
|
cdef int i = 0
|
|
|
|
while i < self.patterns.size():
|
|
|
|
pattern_key = get_pattern_key(self.patterns.at(i))
|
|
|
|
if pattern_key == key:
|
|
|
|
self.patterns.erase(self.patterns.begin()+i)
|
|
|
|
else:
|
|
|
|
i += 1
|
|
|
|
|
|
|
|
def has_key(self, key):
|
|
|
|
"""Check whether the matcher has a rule with a given key.
|
|
|
|
|
|
|
|
key (string or int): The key to check.
|
|
|
|
RETURNS (bool): Whether the matcher has the rule.
|
|
|
|
"""
|
|
|
|
key = self._normalize_key(key)
|
|
|
|
return key in self._patterns
|
|
|
|
|
|
|
|
def get(self, key, default=None):
|
|
|
|
"""Retrieve the pattern stored for a key.
|
|
|
|
|
|
|
|
key (unicode or int): The key to retrieve.
|
|
|
|
RETURNS (tuple): The rule, as an (on_match, patterns) tuple.
|
|
|
|
"""
|
|
|
|
key = self._normalize_key(key)
|
|
|
|
if key not in self._patterns:
|
|
|
|
return default
|
|
|
|
return (self._callbacks[key], self._patterns[key])
|
|
|
|
|
2019-09-18 23:00:33 +03:00
|
|
|
def pipe(self, docs, batch_size=1000, n_threads=-1, return_matches=False,
|
|
|
|
as_tuples=False):
|
2019-03-08 13:42:26 +03:00
|
|
|
"""Match a stream of documents, yielding them in turn.
|
|
|
|
|
|
|
|
docs (iterable): A stream of documents.
|
|
|
|
batch_size (int): Number of documents to accumulate into a working set.
|
2019-09-18 23:00:33 +03:00
|
|
|
return_matches (bool): Yield the match lists along with the docs, making
|
|
|
|
results (doc, matches) tuples.
|
|
|
|
as_tuples (bool): Interpret the input stream as (doc, context) tuples,
|
|
|
|
and yield (result, context) tuples out.
|
|
|
|
If both return_matches and as_tuples are True, the output will
|
|
|
|
be a sequence of ((doc, matches), context) tuples.
|
2019-03-08 13:42:26 +03:00
|
|
|
YIELDS (Doc): Documents, in order.
|
|
|
|
"""
|
2019-03-15 18:38:44 +03:00
|
|
|
if n_threads != -1:
|
|
|
|
deprecation_warning(Warnings.W016)
|
2019-09-18 23:00:33 +03:00
|
|
|
|
|
|
|
if as_tuples:
|
|
|
|
for doc, context in docs:
|
|
|
|
matches = self(doc)
|
|
|
|
if return_matches:
|
|
|
|
yield ((doc, matches), context)
|
|
|
|
else:
|
|
|
|
yield (doc, context)
|
|
|
|
else:
|
|
|
|
for doc in docs:
|
|
|
|
matches = self(doc)
|
|
|
|
if return_matches:
|
|
|
|
yield (doc, matches)
|
|
|
|
else:
|
|
|
|
yield doc
|
2019-03-08 13:42:26 +03:00
|
|
|
|
|
|
|
def __call__(self, Doc doc):
|
|
|
|
"""Find all token sequences matching the supplied pattern.
|
|
|
|
|
|
|
|
doc (Doc): The document to match over.
|
|
|
|
RETURNS (list): A list of `(key, start, end)` tuples,
|
|
|
|
describing the matches. A match tuple describes a span
|
|
|
|
`doc[start:end]`. The `label_id` and `key` are both integers.
|
|
|
|
"""
|
2019-08-21 21:52:36 +03:00
|
|
|
if len(set([LEMMA, POS, TAG]) & self._seen_attrs) > 0 \
|
|
|
|
and not doc.is_tagged:
|
|
|
|
raise ValueError(Errors.E155.format())
|
|
|
|
if DEP in self._seen_attrs and not doc.is_parsed:
|
|
|
|
raise ValueError(Errors.E156.format())
|
2019-03-08 13:42:26 +03:00
|
|
|
matches = find_matches(&self.patterns[0], self.patterns.size(), doc,
|
|
|
|
extensions=self._extensions,
|
|
|
|
predicates=self._extra_predicates)
|
|
|
|
for i, (key, start, end) in enumerate(matches):
|
|
|
|
on_match = self._callbacks.get(key, None)
|
|
|
|
if on_match is not None:
|
|
|
|
on_match(self, doc, i, matches)
|
|
|
|
return matches
|
|
|
|
|
|
|
|
def _normalize_key(self, key):
|
|
|
|
if isinstance(key, basestring):
|
|
|
|
return self.vocab.strings.add(key)
|
|
|
|
else:
|
|
|
|
return key
|
|
|
|
|
|
|
|
|
|
|
|
def unpickle_matcher(vocab, patterns, callbacks):
|
|
|
|
matcher = Matcher(vocab)
|
|
|
|
for key, specs in patterns.items():
|
|
|
|
callback = callbacks.get(key, None)
|
|
|
|
matcher.add(key, callback, *specs)
|
|
|
|
return matcher
|
|
|
|
|
|
|
|
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef find_matches(TokenPatternC** patterns, int n, Doc doc, extensions=None,
|
|
|
|
predicates=tuple()):
|
2019-03-08 13:42:26 +03:00
|
|
|
"""Find matches in a doc, with a compiled array of patterns. Matches are
|
2019-01-21 15:23:15 +03:00
|
|
|
returned as a list of (id, start, end) tuples.
|
|
|
|
|
|
|
|
To augment the compiled patterns, we optionally also take two Python lists.
|
2019-02-07 11:42:25 +03:00
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
The "predicates" list contains functions that take a Python list and return a
|
|
|
|
boolean value. It's mostly used for regular expressions.
|
2019-02-07 11:42:25 +03:00
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
The "extra_getters" list contains functions that take a Python list and return
|
|
|
|
an attr ID. It's mostly used for extension attributes.
|
2019-03-08 13:42:26 +03:00
|
|
|
"""
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef vector[PatternStateC] states
|
|
|
|
cdef vector[MatchC] matches
|
|
|
|
cdef PatternStateC state
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef int i, j, nr_extra_attr
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef Pool mem = Pool()
|
2019-01-21 15:23:15 +03:00
|
|
|
predicate_cache = <char*>mem.alloc(doc.length * len(predicates), sizeof(char))
|
|
|
|
if extensions is not None and len(extensions) >= 1:
|
2019-02-20 23:30:39 +03:00
|
|
|
nr_extra_attr = max(extensions.values()) + 1
|
2019-01-21 15:23:15 +03:00
|
|
|
extra_attr_values = <attr_t*>mem.alloc(doc.length * nr_extra_attr, sizeof(attr_t))
|
|
|
|
else:
|
|
|
|
nr_extra_attr = 0
|
|
|
|
extra_attr_values = <attr_t*>mem.alloc(doc.length, sizeof(attr_t))
|
|
|
|
for i, token in enumerate(doc):
|
|
|
|
for name, index in extensions.items():
|
|
|
|
value = token._.get(name)
|
|
|
|
if isinstance(value, basestring):
|
|
|
|
value = token.vocab.strings[value]
|
|
|
|
extra_attr_values[i * nr_extra_attr + index] = value
|
2018-03-27 20:23:02 +03:00
|
|
|
# Main loop
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef int nr_predicate = len(predicates)
|
2018-03-27 20:23:02 +03:00
|
|
|
for i in range(doc.length):
|
|
|
|
for j in range(n):
|
|
|
|
states.push_back(PatternStateC(patterns[j], i, 0))
|
2019-02-27 12:25:39 +03:00
|
|
|
transition_states(states, matches, predicate_cache,
|
2019-01-21 15:23:15 +03:00
|
|
|
doc[i], extra_attr_values, predicates)
|
|
|
|
extra_attr_values += nr_extra_attr
|
2019-02-27 12:25:39 +03:00
|
|
|
predicate_cache += len(predicates)
|
2018-03-27 20:23:02 +03:00
|
|
|
# Handle matches that end in 0-width patterns
|
|
|
|
finish_states(matches, states)
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
output = []
|
|
|
|
seen = set()
|
|
|
|
for i in range(matches.size()):
|
|
|
|
match = (
|
|
|
|
matches[i].pattern_id,
|
|
|
|
matches[i].start,
|
|
|
|
matches[i].start+matches[i].length
|
|
|
|
)
|
|
|
|
# We need to deduplicate, because we could otherwise arrive at the same
|
|
|
|
# match through two paths, e.g. .?.? matching 'a'. Are we matching the
|
|
|
|
# first .?, or the second .? -- it doesn't matter, it's just one match.
|
|
|
|
if match not in seen:
|
|
|
|
output.append(match)
|
|
|
|
seen.add(match)
|
|
|
|
return output
|
2018-03-27 20:23:02 +03:00
|
|
|
|
|
|
|
|
2018-08-15 17:19:08 +03:00
|
|
|
cdef attr_t get_ent_id(const TokenPatternC* pattern) nogil:
|
2019-07-11 13:55:11 +03:00
|
|
|
# There have been a few bugs here.
|
2018-08-15 17:19:08 +03:00
|
|
|
# The code was originally designed to always have pattern[1].attrs.value
|
|
|
|
# be the ent_id when we get to the end of a pattern. However, Issue #2671
|
|
|
|
# showed this wasn't the case when we had a reject-and-continue before a
|
2019-07-11 13:55:11 +03:00
|
|
|
# match.
|
|
|
|
# The patch to #2671 was wrong though, which came up in #3839.
|
|
|
|
while pattern.attrs.attr != ID:
|
2018-08-15 17:19:08 +03:00
|
|
|
pattern += 1
|
|
|
|
return pattern.attrs.value
|
|
|
|
|
2018-03-27 20:23:02 +03:00
|
|
|
|
|
|
|
cdef void transition_states(vector[PatternStateC]& states, vector[MatchC]& matches,
|
2019-01-21 15:23:15 +03:00
|
|
|
char* cached_py_predicates,
|
|
|
|
Token token, const attr_t* extra_attrs, py_predicates) except *:
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef int q = 0
|
|
|
|
cdef vector[PatternStateC] new_states
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef int nr_predicate = len(py_predicates)
|
2018-03-27 20:23:02 +03:00
|
|
|
for i in range(states.size()):
|
2019-02-20 23:30:39 +03:00
|
|
|
if states[i].pattern.nr_py >= 1:
|
2019-01-21 15:23:15 +03:00
|
|
|
update_predicate_cache(cached_py_predicates,
|
|
|
|
states[i].pattern, token, py_predicates)
|
|
|
|
action = get_action(states[i], token.c, extra_attrs,
|
2019-02-20 23:30:39 +03:00
|
|
|
cached_py_predicates)
|
2018-03-27 20:23:02 +03:00
|
|
|
if action == REJECT:
|
|
|
|
continue
|
2019-02-20 23:30:39 +03:00
|
|
|
# Keep only a subset of states (the active ones). Index q is the
|
|
|
|
# states which are still alive. If we reject a state, we overwrite
|
|
|
|
# it in the states list, because q doesn't advance.
|
2018-03-27 20:23:02 +03:00
|
|
|
state = states[i]
|
|
|
|
states[q] = state
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
while action in (RETRY, RETRY_ADVANCE, RETRY_EXTEND):
|
2018-03-27 20:23:02 +03:00
|
|
|
if action == RETRY_EXTEND:
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
# This handles the 'extend'
|
2018-03-27 20:23:02 +03:00
|
|
|
new_states.push_back(
|
2019-08-21 22:58:04 +03:00
|
|
|
PatternStateC(pattern=states[q].pattern, start=state.start,
|
2018-03-27 20:23:02 +03:00
|
|
|
length=state.length+1))
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
if action == RETRY_ADVANCE:
|
|
|
|
# This handles the 'advance'
|
|
|
|
new_states.push_back(
|
2019-08-21 22:58:04 +03:00
|
|
|
PatternStateC(pattern=states[q].pattern+1, start=state.start,
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
length=state.length+1))
|
2018-03-27 20:23:02 +03:00
|
|
|
states[q].pattern += 1
|
2019-01-21 15:23:15 +03:00
|
|
|
if states[q].pattern.nr_py != 0:
|
|
|
|
update_predicate_cache(cached_py_predicates,
|
|
|
|
states[q].pattern, token, py_predicates)
|
|
|
|
action = get_action(states[q], token.c, extra_attrs,
|
2019-02-20 23:30:39 +03:00
|
|
|
cached_py_predicates)
|
2018-03-27 20:23:02 +03:00
|
|
|
if action == REJECT:
|
|
|
|
pass
|
|
|
|
elif action == ADVANCE:
|
|
|
|
states[q].pattern += 1
|
|
|
|
states[q].length += 1
|
|
|
|
q += 1
|
|
|
|
else:
|
2019-08-22 18:17:07 +03:00
|
|
|
ent_id = get_ent_id(state.pattern)
|
2018-03-27 20:23:02 +03:00
|
|
|
if action == MATCH:
|
|
|
|
matches.push_back(
|
|
|
|
MatchC(pattern_id=ent_id, start=state.start,
|
|
|
|
length=state.length+1))
|
2019-08-21 23:46:56 +03:00
|
|
|
elif action == MATCH_DOUBLE:
|
|
|
|
# push match without last token if length > 0
|
|
|
|
if state.length > 0:
|
|
|
|
matches.push_back(
|
|
|
|
MatchC(pattern_id=ent_id, start=state.start,
|
|
|
|
length=state.length))
|
|
|
|
# push match with last token
|
|
|
|
matches.push_back(
|
|
|
|
MatchC(pattern_id=ent_id, start=state.start,
|
|
|
|
length=state.length+1))
|
2018-03-27 20:23:02 +03:00
|
|
|
elif action == MATCH_REJECT:
|
|
|
|
matches.push_back(
|
|
|
|
MatchC(pattern_id=ent_id, start=state.start,
|
|
|
|
length=state.length))
|
|
|
|
elif action == MATCH_EXTEND:
|
|
|
|
matches.push_back(
|
|
|
|
MatchC(pattern_id=ent_id, start=state.start,
|
|
|
|
length=state.length))
|
|
|
|
states[q].length += 1
|
|
|
|
q += 1
|
|
|
|
states.resize(q)
|
|
|
|
for i in range(new_states.size()):
|
|
|
|
states.push_back(new_states[i])
|
|
|
|
|
|
|
|
|
2019-02-20 23:30:39 +03:00
|
|
|
cdef int update_predicate_cache(char* cache,
|
|
|
|
const TokenPatternC* pattern, Token token, predicates) except -1:
|
2019-01-21 15:23:15 +03:00
|
|
|
# If the state references any extra predicates, check whether they match.
|
|
|
|
# These are cached, so that we don't call these potentially expensive
|
|
|
|
# Python functions more than we need to.
|
|
|
|
for i in range(pattern.nr_py):
|
|
|
|
index = pattern.py_predicates[i]
|
|
|
|
if cache[index] == 0:
|
|
|
|
predicate = predicates[index]
|
|
|
|
result = predicate(token)
|
|
|
|
if result is True:
|
|
|
|
cache[index] = 1
|
|
|
|
elif result is False:
|
|
|
|
cache[index] = -1
|
|
|
|
elif result is None:
|
|
|
|
pass
|
|
|
|
else:
|
2019-03-08 13:42:26 +03:00
|
|
|
raise ValueError(Errors.E125.format(value=result))
|
2019-01-21 15:23:15 +03:00
|
|
|
|
2019-02-07 11:42:25 +03:00
|
|
|
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef void finish_states(vector[MatchC]& matches, vector[PatternStateC]& states) except *:
|
2019-03-08 13:42:26 +03:00
|
|
|
"""Handle states that end in zero-width patterns."""
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef PatternStateC state
|
|
|
|
for i in range(states.size()):
|
|
|
|
state = states[i]
|
|
|
|
while get_quantifier(state) in (ZERO_PLUS, ZERO_ONE):
|
|
|
|
is_final = get_is_final(state)
|
|
|
|
if is_final:
|
2018-08-15 17:19:08 +03:00
|
|
|
ent_id = get_ent_id(state.pattern)
|
2018-03-27 20:23:02 +03:00
|
|
|
matches.push_back(
|
|
|
|
MatchC(pattern_id=ent_id, start=state.start, length=state.length))
|
|
|
|
break
|
|
|
|
else:
|
|
|
|
state.pattern += 1
|
|
|
|
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef action_t get_action(PatternStateC state,
|
|
|
|
const TokenC* token, const attr_t* extra_attrs,
|
2019-02-20 23:30:39 +03:00
|
|
|
const char* predicate_matches) nogil:
|
2019-03-08 13:42:26 +03:00
|
|
|
"""We need to consider:
|
2018-03-27 20:23:02 +03:00
|
|
|
a) Does the token match the specification? [Yes, No]
|
|
|
|
b) What's the quantifier? [1, 0+, ?]
|
|
|
|
c) Is this the last specification? [final, non-final]
|
|
|
|
|
|
|
|
We can transition in the following ways:
|
|
|
|
a) Do we emit a match?
|
|
|
|
b) Do we add a state with (next state, next token)?
|
|
|
|
c) Do we add a state with (next state, same token)?
|
|
|
|
d) Do we add a state with (same state, next token)?
|
|
|
|
|
|
|
|
We'll code the actions as boolean strings, so 0000 means no to all 4,
|
|
|
|
1000 means match but no states added, etc.
|
2018-11-14 21:10:21 +03:00
|
|
|
|
2018-03-27 20:23:02 +03:00
|
|
|
1:
|
|
|
|
Yes, final:
|
|
|
|
1000
|
|
|
|
Yes, non-final:
|
|
|
|
0100
|
|
|
|
No, final:
|
|
|
|
0000
|
|
|
|
No, non-final
|
|
|
|
0000
|
|
|
|
0+:
|
|
|
|
Yes, final:
|
|
|
|
1001
|
|
|
|
Yes, non-final:
|
|
|
|
0011
|
|
|
|
No, final:
|
|
|
|
1000 (note: Don't include last token!)
|
|
|
|
No, non-final:
|
|
|
|
0010
|
|
|
|
?:
|
|
|
|
Yes, final:
|
|
|
|
1000
|
|
|
|
Yes, non-final:
|
|
|
|
0100
|
|
|
|
No, final:
|
|
|
|
1000 (note: Don't include last token!)
|
|
|
|
No, non-final:
|
|
|
|
0010
|
|
|
|
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
Possible combinations: 1000, 0100, 0000, 1001, 0110, 0011, 0010,
|
2018-11-14 21:10:21 +03:00
|
|
|
|
2018-03-27 20:23:02 +03:00
|
|
|
We'll name the bits "match", "advance", "retry", "extend"
|
|
|
|
REJECT = 0000
|
|
|
|
MATCH = 1000
|
|
|
|
ADVANCE = 0100
|
|
|
|
RETRY = 0010
|
|
|
|
MATCH_EXTEND = 1001
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
RETRY_ADVANCE = 0110
|
2018-03-27 20:23:02 +03:00
|
|
|
RETRY_EXTEND = 0011
|
|
|
|
MATCH_REJECT = 2000 # Match, but don't include last token
|
2019-08-21 23:46:56 +03:00
|
|
|
MATCH_DOUBLE = 3000 # Match both with and without last token
|
2018-03-27 20:23:02 +03:00
|
|
|
|
|
|
|
Problem: If a quantifier is matching, we're adding a lot of open partials
|
2019-03-08 13:42:26 +03:00
|
|
|
"""
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef char is_match
|
2019-02-20 23:30:39 +03:00
|
|
|
is_match = get_is_match(state, token, extra_attrs, predicate_matches)
|
2018-03-27 20:23:02 +03:00
|
|
|
quantifier = get_quantifier(state)
|
|
|
|
is_final = get_is_final(state)
|
|
|
|
if quantifier == ZERO:
|
|
|
|
is_match = not is_match
|
|
|
|
quantifier = ONE
|
|
|
|
if quantifier == ONE:
|
|
|
|
if is_match and is_final:
|
|
|
|
# Yes, final: 1000
|
|
|
|
return MATCH
|
|
|
|
elif is_match and not is_final:
|
|
|
|
# Yes, non-final: 0100
|
|
|
|
return ADVANCE
|
|
|
|
elif not is_match and is_final:
|
|
|
|
# No, final: 0000
|
|
|
|
return REJECT
|
|
|
|
else:
|
|
|
|
return REJECT
|
|
|
|
elif quantifier == ZERO_PLUS:
|
|
|
|
if is_match and is_final:
|
|
|
|
# Yes, final: 1001
|
|
|
|
return MATCH_EXTEND
|
|
|
|
elif is_match and not is_final:
|
|
|
|
# Yes, non-final: 0011
|
|
|
|
return RETRY_EXTEND
|
|
|
|
elif not is_match and is_final:
|
|
|
|
# No, final 2000 (note: Don't include last token!)
|
|
|
|
return MATCH_REJECT
|
|
|
|
else:
|
|
|
|
# No, non-final 0010
|
|
|
|
return RETRY
|
|
|
|
elif quantifier == ZERO_ONE:
|
|
|
|
if is_match and is_final:
|
2019-08-21 23:46:56 +03:00
|
|
|
# Yes, final: 3000
|
|
|
|
# To cater for a pattern ending in "?", we need to add
|
|
|
|
# a match both with and without the last token
|
|
|
|
return MATCH_DOUBLE
|
2018-03-27 20:23:02 +03:00
|
|
|
elif is_match and not is_final:
|
Fix behaviour of Matcher's ? quantifier for v2.1 (#3105)
* Add failing test for matcher bug #3009
* Deduplicate matches from Matcher
* Update matcher ? quantifier test
* Fix bug with ? quantifier in Matcher
The ? quantifier indicates a token may occur zero or one times. If the
token pattern fit, the matcher would fail to consider valid matches
where the token pattern did not fit. Consider a simple regex like:
.?b
If we have the string 'b', the .? part will fit --- but then the 'b' in
the pattern will not fit, leaving us with no match. The same bug left us
with too few matches in some cases. For instance, consider:
.?.?
If we have a string of length two, like 'ab', we actually have three
possible matches here: [a, b, ab]. We were only recovering 'ab'. This
should now be fixed. Note that the fix also uncovered another bug, where
we weren't deduplicating the matches. There are actually two ways we
might match 'a' and two ways we might match 'b': as the second token of the pattern,
or as the first token of the pattern. This ambiguity is spurious, so we
need to deduplicate.
Closes #2464 and #3009
* Fix Python2
2018-12-29 18:18:09 +03:00
|
|
|
# Yes, non-final: 0110
|
|
|
|
# We need both branches here, consider a pair like:
|
|
|
|
# pattern: .?b string: b
|
|
|
|
# If we 'ADVANCE' on the .?, we miss the match.
|
|
|
|
return RETRY_ADVANCE
|
2018-03-27 20:23:02 +03:00
|
|
|
elif not is_match and is_final:
|
|
|
|
# No, final 2000 (note: Don't include last token!)
|
|
|
|
return MATCH_REJECT
|
|
|
|
else:
|
|
|
|
# No, non-final 0010
|
|
|
|
return RETRY
|
|
|
|
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef char get_is_match(PatternStateC state,
|
|
|
|
const TokenC* token, const attr_t* extra_attrs,
|
2019-02-20 23:30:39 +03:00
|
|
|
const char* predicate_matches) nogil:
|
|
|
|
for i in range(state.pattern.nr_py):
|
|
|
|
if predicate_matches[state.pattern.py_predicates[i]] == -1:
|
2019-01-21 15:23:15 +03:00
|
|
|
return 0
|
2018-03-27 20:23:02 +03:00
|
|
|
spec = state.pattern
|
|
|
|
for attr in spec.attrs[:spec.nr_attr]:
|
|
|
|
if get_token_attr(token, attr.attr) != attr.value:
|
|
|
|
return 0
|
2019-01-21 15:23:15 +03:00
|
|
|
for i in range(spec.nr_extra_attr):
|
|
|
|
if spec.extra_attrs[i].value != extra_attrs[spec.extra_attrs[i].index]:
|
|
|
|
return 0
|
|
|
|
return True
|
2018-03-27 20:23:02 +03:00
|
|
|
|
|
|
|
|
|
|
|
cdef char get_is_final(PatternStateC state) nogil:
|
|
|
|
if state.pattern[1].attrs[0].attr == ID and state.pattern[1].nr_attr == 0:
|
|
|
|
return 1
|
|
|
|
else:
|
|
|
|
return 0
|
2015-08-04 16:55:28 +03:00
|
|
|
|
|
|
|
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef char get_quantifier(PatternStateC state) nogil:
|
|
|
|
return state.pattern.quantifier
|
2016-09-21 15:54:55 +03:00
|
|
|
|
💫 Port master changes over to develop (#2979)
* Create aryaprabhudesai.md (#2681)
* Update _install.jade (#2688)
Typo fix: "models" -> "model"
* Add FAC to spacy.explain (resolves #2706)
* Remove docstrings for deprecated arguments (see #2703)
* When calling getoption() in conftest.py, pass a default option (#2709)
* When calling getoption() in conftest.py, pass a default option
This is necessary to allow testing an installed spacy by running:
pytest --pyargs spacy
* Add contributor agreement
* update bengali token rules for hyphen and digits (#2731)
* Less norm computations in token similarity (#2730)
* Less norm computations in token similarity
* Contributor agreement
* Remove ')' for clarity (#2737)
Sorry, don't mean to be nitpicky, I just noticed this when going through the CLI and thought it was a quick fix. That said, if this was intention than please let me know.
* added contributor agreement for mbkupfer (#2738)
* Basic support for Telugu language (#2751)
* Lex _attrs for polish language (#2750)
* Signed spaCy contributor agreement
* Added polish version of english lex_attrs
* Introduces a bulk merge function, in order to solve issue #653 (#2696)
* Fix comment
* Introduce bulk merge to increase performance on many span merges
* Sign contributor agreement
* Implement pull request suggestions
* Describe converters more explicitly (see #2643)
* Add multi-threading note to Language.pipe (resolves #2582) [ci skip]
* Fix formatting
* Fix dependency scheme docs (closes #2705) [ci skip]
* Don't set stop word in example (closes #2657) [ci skip]
* Add words to portuguese language _num_words (#2759)
* Add words to portuguese language _num_words
* Add words to portuguese language _num_words
* Update Indonesian model (#2752)
* adding e-KTP in tokenizer exceptions list
* add exception token
* removing lines with containing space as it won't matter since we use .split() method in the end, added new tokens in exception
* add tokenizer exceptions list
* combining base_norms with norm_exceptions
* adding norm_exception
* fix double key in lemmatizer
* remove unused import on punctuation.py
* reformat stop_words to reduce number of lines, improve readibility
* updating tokenizer exception
* implement is_currency for lang/id
* adding orth_first_upper in tokenizer_exceptions
* update the norm_exception list
* remove bunch of abbreviations
* adding contributors file
* Fixed spaCy+Keras example (#2763)
* bug fixes in keras example
* created contributor agreement
* Adding French hyphenated first name (#2786)
* Fix typo (closes #2784)
* Fix typo (#2795) [ci skip]
Fixed typo on line 6 "regcognizer --> recognizer"
* Adding basic support for Sinhala language. (#2788)
* adding Sinhala language package, stop words, examples and lex_attrs.
* Adding contributor agreement
* Updating contributor agreement
* Also include lowercase norm exceptions
* Fix error (#2802)
* Fix error
ValueError: cannot resize an array that references or is referenced
by another array in this way. Use the resize function
* added spaCy Contributor Agreement
* Add charlax's contributor agreement (#2805)
* agreement of contributor, may I introduce a tiny pl languge contribution (#2799)
* Contributors agreement
* Contributors agreement
* Contributors agreement
* Add jupyter=True to displacy.render in documentation (#2806)
* Revert "Also include lowercase norm exceptions"
This reverts commit 70f4e8adf37cfcfab60be2b97d6deae949b30e9e.
* Remove deprecated encoding argument to msgpack
* Set up dependency tree pattern matching skeleton (#2732)
* Fix bug when too many entity types. Fixes #2800
* Fix Python 2 test failure
* Require older msgpack-numpy
* Restore encoding arg on msgpack-numpy
* Try to fix version pin for msgpack-numpy
* Update Portuguese Language (#2790)
* Add words to portuguese language _num_words
* Add words to portuguese language _num_words
* Portuguese - Add/remove stopwords, fix tokenizer, add currency symbols
* Extended punctuation and norm_exceptions in the Portuguese language
* Correct error in spacy universe docs concerning spacy-lookup (#2814)
* Update Keras Example for (Parikh et al, 2016) implementation (#2803)
* bug fixes in keras example
* created contributor agreement
* baseline for Parikh model
* initial version of parikh 2016 implemented
* tested asymmetric models
* fixed grevious error in normalization
* use standard SNLI test file
* begin to rework parikh example
* initial version of running example
* start to document the new version
* start to document the new version
* Update Decompositional Attention.ipynb
* fixed calls to similarity
* updated the README
* import sys package duh
* simplified indexing on mapping word to IDs
* stupid python indent error
* added code from https://github.com/tensorflow/tensorflow/issues/3388 for tf bug workaround
* Fix typo (closes #2815) [ci skip]
* Update regex version dependency
* Set version to 2.0.13.dev3
* Skip seemingly problematic test
* Remove problematic test
* Try previous version of regex
* Revert "Remove problematic test"
This reverts commit bdebbef45552d698d390aa430b527ee27830f11b.
* Unskip test
* Try older version of regex
* 💫 Update training examples and use minibatching (#2830)
<!--- Provide a general summary of your changes in the title. -->
## Description
Update the training examples in `/examples/training` to show usage of spaCy's `minibatch` and `compounding` helpers ([see here](https://spacy.io/usage/training#tips-batch-size) for details). The lack of batching in the examples has caused some confusion in the past, especially for beginners who would copy-paste the examples, update them with large training sets and experienced slow and unsatisfying results.
### Types of change
enhancements
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
* Visual C++ link updated (#2842) (closes #2841) [ci skip]
* New landing page
* Add contribution agreement
* Correcting lang/ru/examples.py (#2845)
* Correct some grammatical inaccuracies in lang\ru\examples.py; filled Contributor Agreement
* Correct some grammatical inaccuracies in lang\ru\examples.py
* Move contributor agreement to separate file
* Set version to 2.0.13.dev4
* Add Persian(Farsi) language support (#2797)
* Also include lowercase norm exceptions
* Remove in favour of https://github.com/explosion/spaCy/graphs/contributors
* Rule-based French Lemmatizer (#2818)
<!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
issue number. If your PR is still a work in progress, that's totally fine – just
include a note to let us know. -->
Add a rule-based French Lemmatizer following the english one and the excellent PR for [greek language optimizations](https://github.com/explosion/spaCy/pull/2558) to adapt the Lemmatizer class.
### Types of change
<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
or new feature, or a change to the documentation? -->
- Lemma dictionary used can be found [here](http://infolingu.univ-mlv.fr/DonneesLinguistiques/Dictionnaires/telechargement.html), I used the XML version.
- Add several files containing exhaustive list of words for each part of speech
- Add some lemma rules
- Add POS that are not checked in the standard Lemmatizer, i.e PRON, DET, ADV and AUX
- Modify the Lemmatizer class to check in lookup table as a last resort if POS not mentionned
- Modify the lemmatize function to check in lookup table as a last resort
- Init files are updated so the model can support all the functionalities mentioned above
- Add words to tokenizer_exceptions_list.py in respect to regex used in tokenizer_exceptions.py
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [X] I have submitted the spaCy Contributor Agreement.
- [X] I ran the tests, and all new and existing tests passed.
- [X] My changes don't require a change to the documentation, or if they do, I've added all required information.
* Set version to 2.0.13
* Fix formatting and consistency
* Update docs for new version [ci skip]
* Increment version [ci skip]
* Add info on wheels [ci skip]
* Adding "This is a sentence" example to Sinhala (#2846)
* Add wheels badge
* Update badge [ci skip]
* Update README.rst [ci skip]
* Update murmurhash pin
* Increment version to 2.0.14.dev0
* Update GPU docs for v2.0.14
* Add wheel to setup_requires
* Import prefer_gpu and require_gpu functions from Thinc
* Add tests for prefer_gpu() and require_gpu()
* Update requirements and setup.py
* Workaround bug in thinc require_gpu
* Set version to v2.0.14
* Update push-tag script
* Unhack prefer_gpu
* Require thinc 6.10.6
* Update prefer_gpu and require_gpu docs [ci skip]
* Fix specifiers for GPU
* Set version to 2.0.14.dev1
* Set version to 2.0.14
* Update Thinc version pin
* Increment version
* Fix msgpack-numpy version pin
* Increment version
* Update version to 2.0.16
* Update version [ci skip]
* Redundant ')' in the Stop words' example (#2856)
<!--- Provide a general summary of your changes in the title. -->
## Description
<!--- Use this section to describe your changes. If your changes required
testing, include information about the testing environment and the tests you
ran. If your test fixes a bug reported in an issue, don't forget to include the
issue number. If your PR is still a work in progress, that's totally fine – just
include a note to let us know. -->
### Types of change
<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
or new feature, or a change to the documentation? -->
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [ ] I have submitted the spaCy Contributor Agreement.
- [ ] I ran the tests, and all new and existing tests passed.
- [ ] My changes don't require a change to the documentation, or if they do, I've added all required information.
* Documentation improvement regarding joblib and SO (#2867)
Some documentation improvements
## Description
1. Fixed the dead URL to joblib
2. Fixed Stack Overflow brand name (with space)
### Types of change
Documentation
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
* raise error when setting overlapping entities as doc.ents (#2880)
* Fix out-of-bounds access in NER training
The helper method state.B(1) gets the index of the first token of the
buffer, or -1 if no such token exists. Normally this is safe because we
pass this to functions like state.safe_get(), which returns an empty
token. Here we used it directly as an array index, which is not okay!
This error may have been the cause of out-of-bounds access errors during
training. Similar errors may still be around, so much be hunted down.
Hunting this one down took a long time...I printed out values across
training runs and diffed, looking for points of divergence between
runs, when no randomness should be allowed.
* Change PyThaiNLP Url (#2876)
* Fix missing comma
* Add example showing a fix-up rule for space entities
* Set version to 2.0.17.dev0
* Update regex version
* Revert "Update regex version"
This reverts commit 62358dd867d15bc6a475942dff34effba69dd70a.
* Try setting older regex version, to align with conda
* Set version to 2.0.17
* Add spacy-js to universe [ci-skip]
* Add spacy-raspberry to universe (closes #2889)
* Add script to validate universe json [ci skip]
* Removed space in docs + added contributor indo (#2909)
* - removed unneeded space in documentation
* - added contributor info
* Allow input text of length up to max_length, inclusive (#2922)
* Include universe spec for spacy-wordnet component (#2919)
* feat: include universe spec for spacy-wordnet component
* chore: include spaCy contributor agreement
* Minor formatting changes [ci skip]
* Fix image [ci skip]
Twitter URL doesn't work on live site
* Check if the word is in one of the regular lists specific to each POS (#2886)
* 💫 Create random IDs for SVGs to prevent ID clashes (#2927)
Resolves #2924.
## Description
Fixes problem where multiple visualizations in Jupyter notebooks would have clashing arc IDs, resulting in weirdly positioned arc labels. Generating a random ID prefix so even identical parses won't receive the same IDs for consistency (even if effect of ID clash isn't noticable here.)
### Types of change
bug fix
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
* Fix typo [ci skip]
* fixes symbolic link on py3 and windows (#2949)
* fixes symbolic link on py3 and windows
during setup of spacy using command
python -m spacy link en_core_web_sm en
closes #2948
* Update spacy/compat.py
Co-Authored-By: cicorias <cicorias@users.noreply.github.com>
* Fix formatting
* Update universe [ci skip]
* Catalan Language Support (#2940)
* Catalan language Support
* Ddding Catalan to documentation
* Sort languages alphabetically [ci skip]
* Update tests for pytest 4.x (#2965)
<!--- Provide a general summary of your changes in the title. -->
## Description
- [x] Replace marks in params for pytest 4.0 compat ([see here](https://docs.pytest.org/en/latest/deprecations.html#marks-in-pytest-mark-parametrize))
- [x] Un-xfail passing tests (some fixes in a recent update resolved a bunch of issues, but tests were apparently never updated here)
### Types of change
<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
or new feature, or a change to the documentation? -->
## Checklist
<!--- Before you submit the PR, go over this checklist and make sure you can
tick off all the boxes. [] -> [x] -->
- [x] I have submitted the spaCy Contributor Agreement.
- [x] I ran the tests, and all new and existing tests passed.
- [x] My changes don't require a change to the documentation, or if they do, I've added all required information.
* Fix regex pin to harmonize with conda (#2964)
* Update README.rst
* Fix bug where Vocab.prune_vector did not use 'batch_size' (#2977)
Fixes #2976
* Fix typo
* Fix typo
* Remove duplicate file
* Require thinc 7.0.0.dev2
Fixes bug in gpu_ops that would use cupy instead of numpy on CPU
* Add missing import
* Fix error IDs
* Fix tests
2018-11-29 18:30:29 +03:00
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
cdef TokenPatternC* init_pattern(Pool mem, attr_t entity_id, object token_specs) except NULL:
|
2016-09-21 15:54:55 +03:00
|
|
|
pattern = <TokenPatternC*>mem.alloc(len(token_specs) + 1, sizeof(TokenPatternC))
|
2019-02-20 23:30:39 +03:00
|
|
|
cdef int i, index
|
2019-01-21 15:23:15 +03:00
|
|
|
for i, (quantifier, spec, extensions, predicates) in enumerate(token_specs):
|
2016-09-21 15:54:55 +03:00
|
|
|
pattern[i].quantifier = quantifier
|
|
|
|
pattern[i].attrs = <AttrValueC*>mem.alloc(len(spec), sizeof(AttrValueC))
|
|
|
|
pattern[i].nr_attr = len(spec)
|
2015-08-05 02:05:54 +03:00
|
|
|
for j, (attr, value) in enumerate(spec):
|
2016-09-21 15:54:55 +03:00
|
|
|
pattern[i].attrs[j].attr = attr
|
|
|
|
pattern[i].attrs[j].value = value
|
2019-01-21 15:23:15 +03:00
|
|
|
pattern[i].extra_attrs = <IndexValueC*>mem.alloc(len(extensions), sizeof(IndexValueC))
|
|
|
|
for j, (index, value) in enumerate(extensions):
|
|
|
|
pattern[i].extra_attrs[j].index = index
|
|
|
|
pattern[i].extra_attrs[j].value = value
|
|
|
|
pattern[i].nr_extra_attr = len(extensions)
|
|
|
|
pattern[i].py_predicates = <int32_t*>mem.alloc(len(predicates), sizeof(int32_t))
|
|
|
|
for j, index in enumerate(predicates):
|
|
|
|
pattern[i].py_predicates[j] = index
|
|
|
|
pattern[i].nr_py = len(predicates)
|
2018-03-27 20:23:02 +03:00
|
|
|
pattern[i].key = hash64(pattern[i].attrs, pattern[i].nr_attr * sizeof(AttrValueC), 0)
|
2015-08-05 02:05:54 +03:00
|
|
|
i = len(token_specs)
|
2017-05-20 14:54:53 +03:00
|
|
|
pattern[i].attrs = <AttrValueC*>mem.alloc(2, sizeof(AttrValueC))
|
2016-09-21 15:54:55 +03:00
|
|
|
pattern[i].attrs[0].attr = ID
|
|
|
|
pattern[i].attrs[0].value = entity_id
|
|
|
|
pattern[i].nr_attr = 0
|
2019-02-20 23:30:39 +03:00
|
|
|
pattern[i].nr_extra_attr = 0
|
|
|
|
pattern[i].nr_py = 0
|
2015-08-05 02:05:54 +03:00
|
|
|
return pattern
|
|
|
|
|
|
|
|
|
2018-03-27 20:23:02 +03:00
|
|
|
cdef attr_t get_pattern_key(const TokenPatternC* pattern) nogil:
|
2019-02-20 23:30:39 +03:00
|
|
|
while pattern.nr_attr != 0 or pattern.nr_extra_attr != 0 or pattern.nr_py != 0:
|
2017-05-20 14:54:53 +03:00
|
|
|
pattern += 1
|
|
|
|
id_attr = pattern[0].attrs[0]
|
2018-04-03 16:50:31 +03:00
|
|
|
if id_attr.attr != ID:
|
2018-04-29 16:48:34 +03:00
|
|
|
with gil:
|
|
|
|
raise ValueError(Errors.E074.format(attr=ID, bad_attr=id_attr.attr))
|
2017-05-20 14:54:53 +03:00
|
|
|
return id_attr.value
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
|
|
|
|
def _preprocess_pattern(token_specs, string_store, extensions_table, extra_predicates):
|
|
|
|
"""This function interprets the pattern, converting the various bits of
|
|
|
|
syntactic sugar before we compile it into a struct with init_pattern.
|
|
|
|
|
|
|
|
We need to split the pattern up into three parts:
|
|
|
|
* Normal attribute/value pairs, which are stored on either the token or lexeme,
|
|
|
|
can be handled directly.
|
|
|
|
* Extension attributes are handled specially, as we need to prefetch the
|
|
|
|
values from Python for the doc before we begin matching.
|
|
|
|
* Extra predicates also call Python functions, so we have to create the
|
|
|
|
functions and store them. So we store these specially as well.
|
|
|
|
* Extension attributes that have extra predicates are stored within the
|
|
|
|
extra_predicates.
|
|
|
|
"""
|
2016-09-21 15:54:55 +03:00
|
|
|
tokens = []
|
2015-08-06 15:33:21 +03:00
|
|
|
for spec in token_specs:
|
2017-10-07 04:36:15 +03:00
|
|
|
if not spec:
|
|
|
|
# Signifier for 'any token'
|
2019-01-21 15:23:15 +03:00
|
|
|
tokens.append((ONE, [(NULL_ATTR, 0)], [], []))
|
2017-10-07 04:36:15 +03:00
|
|
|
continue
|
2019-08-21 15:00:37 +03:00
|
|
|
if not isinstance(spec, dict):
|
|
|
|
raise ValueError(Errors.E154.format())
|
2019-01-21 15:23:15 +03:00
|
|
|
ops = _get_operators(spec)
|
|
|
|
attr_values = _get_attr_values(spec, string_store)
|
|
|
|
extensions = _get_extensions(spec, string_store, extensions_table)
|
2019-02-20 23:30:39 +03:00
|
|
|
predicates = _get_extra_predicates(spec, extra_predicates)
|
2016-09-21 15:54:55 +03:00
|
|
|
for op in ops:
|
2019-01-21 15:23:15 +03:00
|
|
|
tokens.append((op, list(attr_values), list(extensions), list(predicates)))
|
2016-09-21 15:54:55 +03:00
|
|
|
return tokens
|
2015-10-08 18:00:45 +03:00
|
|
|
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
def _get_attr_values(spec, string_store):
|
|
|
|
attr_values = []
|
|
|
|
for attr, value in spec.items():
|
|
|
|
if isinstance(attr, basestring):
|
2019-08-21 15:00:37 +03:00
|
|
|
attr = attr.upper()
|
2019-01-21 15:23:15 +03:00
|
|
|
if attr == '_':
|
|
|
|
continue
|
2019-08-21 15:00:37 +03:00
|
|
|
elif attr == "OP":
|
2019-01-21 15:23:15 +03:00
|
|
|
continue
|
2019-08-21 15:00:37 +03:00
|
|
|
if attr == "TEXT":
|
2019-03-08 13:42:26 +03:00
|
|
|
attr = "ORTH"
|
2019-08-21 15:00:37 +03:00
|
|
|
if attr not in TOKEN_PATTERN_SCHEMA["items"]["properties"]:
|
|
|
|
raise ValueError(Errors.E152.format(attr=attr))
|
|
|
|
attr = IDS.get(attr)
|
2019-01-21 15:23:15 +03:00
|
|
|
if isinstance(value, basestring):
|
|
|
|
value = string_store.add(value)
|
|
|
|
elif isinstance(value, bool):
|
|
|
|
value = int(value)
|
|
|
|
elif isinstance(value, dict):
|
|
|
|
continue
|
2019-08-21 15:00:37 +03:00
|
|
|
else:
|
|
|
|
raise ValueError(Errors.E153.format(vtype=type(value).__name__))
|
2019-01-21 15:23:15 +03:00
|
|
|
if attr is not None:
|
|
|
|
attr_values.append((attr, value))
|
2019-08-21 15:00:37 +03:00
|
|
|
else:
|
|
|
|
# should be caught above using TOKEN_PATTERN_SCHEMA
|
|
|
|
raise ValueError(Errors.E152.format(attr=attr))
|
2019-01-21 15:23:15 +03:00
|
|
|
return attr_values
|
|
|
|
|
2019-03-08 13:42:26 +03:00
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
# These predicate helper classes are used to match the REGEX, IN, >= etc
|
|
|
|
# extensions to the matcher introduced in #3173.
|
|
|
|
|
|
|
|
class _RegexPredicate(object):
|
2019-03-08 13:42:26 +03:00
|
|
|
operators = ("REGEX",)
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
def __init__(self, i, attr, value, predicate, is_extension=False):
|
|
|
|
self.i = i
|
|
|
|
self.attr = attr
|
|
|
|
self.value = re.compile(value)
|
|
|
|
self.predicate = predicate
|
|
|
|
self.is_extension = is_extension
|
2019-02-20 23:30:39 +03:00
|
|
|
self.key = (attr, self.predicate, srsly.json_dumps(value, sort_keys=True))
|
2019-03-08 13:42:26 +03:00
|
|
|
if self.predicate not in self.operators:
|
|
|
|
raise ValueError(Errors.E126.format(good=self.operators, bad=self.predicate))
|
2019-01-21 15:23:15 +03:00
|
|
|
|
|
|
|
def __call__(self, Token token):
|
|
|
|
if self.is_extension:
|
|
|
|
value = token._.get(self.attr)
|
|
|
|
else:
|
|
|
|
value = token.vocab.strings[get_token_attr(token.c, self.attr)]
|
|
|
|
return bool(self.value.search(value))
|
|
|
|
|
|
|
|
|
|
|
|
class _SetMemberPredicate(object):
|
2019-03-08 13:42:26 +03:00
|
|
|
operators = ("IN", "NOT_IN")
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
def __init__(self, i, attr, value, predicate, is_extension=False):
|
|
|
|
self.i = i
|
|
|
|
self.attr = attr
|
|
|
|
self.value = set(get_string_id(v) for v in value)
|
|
|
|
self.predicate = predicate
|
|
|
|
self.is_extension = is_extension
|
2019-02-20 23:30:39 +03:00
|
|
|
self.key = (attr, self.predicate, srsly.json_dumps(value, sort_keys=True))
|
2019-03-08 13:42:26 +03:00
|
|
|
if self.predicate not in self.operators:
|
|
|
|
raise ValueError(Errors.E126.format(good=self.operators, bad=self.predicate))
|
2019-01-21 15:23:15 +03:00
|
|
|
|
|
|
|
def __call__(self, Token token):
|
|
|
|
if self.is_extension:
|
|
|
|
value = get_string_id(token._.get(self.attr))
|
|
|
|
else:
|
|
|
|
value = get_token_attr(token.c, self.attr)
|
2019-03-08 13:42:26 +03:00
|
|
|
if self.predicate == "IN":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value in self.value
|
|
|
|
else:
|
|
|
|
return value not in self.value
|
|
|
|
|
2019-02-20 23:30:39 +03:00
|
|
|
def __repr__(self):
|
2019-03-08 13:42:26 +03:00
|
|
|
return repr(("SetMemberPredicate", self.i, self.attr, self.value, self.predicate))
|
2019-02-20 23:30:39 +03:00
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
|
|
|
|
class _ComparisonPredicate(object):
|
2019-03-08 13:42:26 +03:00
|
|
|
operators = ("==", "!=", ">=", "<=", ">", "<")
|
|
|
|
|
2019-01-21 15:23:15 +03:00
|
|
|
def __init__(self, i, attr, value, predicate, is_extension=False):
|
|
|
|
self.i = i
|
|
|
|
self.attr = attr
|
|
|
|
self.value = value
|
|
|
|
self.predicate = predicate
|
|
|
|
self.is_extension = is_extension
|
2019-02-20 23:30:39 +03:00
|
|
|
self.key = (attr, self.predicate, srsly.json_dumps(value, sort_keys=True))
|
2019-03-08 13:42:26 +03:00
|
|
|
if self.predicate not in self.operators:
|
|
|
|
raise ValueError(Errors.E126.format(good=self.operators, bad=self.predicate))
|
2019-01-21 15:23:15 +03:00
|
|
|
|
|
|
|
def __call__(self, Token token):
|
|
|
|
if self.is_extension:
|
|
|
|
value = token._.get(self.attr)
|
|
|
|
else:
|
|
|
|
value = get_token_attr(token.c, self.attr)
|
2019-03-08 13:42:26 +03:00
|
|
|
if self.predicate == "==":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value == self.value
|
2019-03-08 13:42:26 +03:00
|
|
|
if self.predicate == "!=":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value != self.value
|
2019-03-08 13:42:26 +03:00
|
|
|
elif self.predicate == ">=":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value >= self.value
|
2019-03-08 13:42:26 +03:00
|
|
|
elif self.predicate == "<=":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value <= self.value
|
2019-03-08 13:42:26 +03:00
|
|
|
elif self.predicate == ">":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value > self.value
|
2019-03-08 13:42:26 +03:00
|
|
|
elif self.predicate == "<":
|
2019-01-21 15:23:15 +03:00
|
|
|
return value < self.value
|
|
|
|
|
|
|
|
|
2019-02-20 23:30:39 +03:00
|
|
|
def _get_extra_predicates(spec, extra_predicates):
|
2019-01-21 15:23:15 +03:00
|
|
|
predicate_types = {
|
2019-03-08 13:42:26 +03:00
|
|
|
"REGEX": _RegexPredicate,
|
|
|
|
"IN": _SetMemberPredicate,
|
|
|
|
"NOT_IN": _SetMemberPredicate,
|
|
|
|
"==": _ComparisonPredicate,
|
|
|
|
">=": _ComparisonPredicate,
|
|
|
|
"<=": _ComparisonPredicate,
|
|
|
|
">": _ComparisonPredicate,
|
|
|
|
"<": _ComparisonPredicate,
|
2019-01-21 15:23:15 +03:00
|
|
|
}
|
2019-02-20 23:30:39 +03:00
|
|
|
seen_predicates = {pred.key: pred.i for pred in extra_predicates}
|
2019-01-21 15:23:15 +03:00
|
|
|
output = []
|
|
|
|
for attr, value in spec.items():
|
|
|
|
if isinstance(attr, basestring):
|
2019-03-08 13:42:26 +03:00
|
|
|
if attr == "_":
|
2019-01-21 15:23:15 +03:00
|
|
|
output.extend(
|
|
|
|
_get_extension_extra_predicates(
|
|
|
|
value, extra_predicates, predicate_types,
|
|
|
|
seen_predicates))
|
|
|
|
continue
|
2019-03-08 13:42:26 +03:00
|
|
|
elif attr.upper() == "OP":
|
2019-01-21 15:23:15 +03:00
|
|
|
continue
|
2019-03-08 13:42:26 +03:00
|
|
|
if attr.upper() == "TEXT":
|
|
|
|
attr = "ORTH"
|
2019-01-21 15:23:15 +03:00
|
|
|
attr = IDS.get(attr.upper())
|
|
|
|
if isinstance(value, dict):
|
|
|
|
for type_, cls in predicate_types.items():
|
|
|
|
if type_ in value:
|
2019-02-20 23:30:39 +03:00
|
|
|
predicate = cls(len(extra_predicates), attr, value[type_], type_)
|
2019-01-21 15:23:15 +03:00
|
|
|
# Don't create a redundant predicates.
|
|
|
|
# This helps with efficiency, as we're caching the results.
|
2019-02-20 23:30:39 +03:00
|
|
|
if predicate.key in seen_predicates:
|
|
|
|
output.append(seen_predicates[predicate.key])
|
2019-01-21 15:23:15 +03:00
|
|
|
else:
|
|
|
|
extra_predicates.append(predicate)
|
|
|
|
output.append(predicate.i)
|
2019-02-20 23:30:39 +03:00
|
|
|
seen_predicates[predicate.key] = predicate.i
|
2019-01-21 15:23:15 +03:00
|
|
|
return output
|
|
|
|
|
|
|
|
|
|
|
|
def _get_extension_extra_predicates(spec, extra_predicates, predicate_types,
|
|
|
|
seen_predicates):
|
|
|
|
output = []
|
|
|
|
for attr, value in spec.items():
|
|
|
|
if isinstance(value, dict):
|
|
|
|
for type_, cls in predicate_types.items():
|
|
|
|
if type_ in value:
|
|
|
|
key = (attr, type_, srsly.json_dumps(value[type_], sort_keys=True))
|
|
|
|
if key in seen_predicates:
|
|
|
|
output.append(seen_predicates[key])
|
|
|
|
else:
|
|
|
|
predicate = cls(len(extra_predicates), attr, value[type_], type_,
|
|
|
|
is_extension=True)
|
|
|
|
extra_predicates.append(predicate)
|
|
|
|
output.append(predicate.i)
|
|
|
|
seen_predicates[key] = predicate.i
|
|
|
|
return output
|
|
|
|
|
|
|
|
|
|
|
|
def _get_operators(spec):
|
|
|
|
# Support 'syntactic sugar' operator '+', as combination of ONE, ZERO_PLUS
|
2019-03-08 13:42:26 +03:00
|
|
|
lookup = {"*": (ZERO_PLUS,), "+": (ONE, ZERO_PLUS),
|
|
|
|
"?": (ZERO_ONE,), "1": (ONE,), "!": (ZERO,)}
|
2019-01-21 15:23:15 +03:00
|
|
|
# Fix casing
|
|
|
|
spec = {key.upper(): values for key, values in spec.items()
|
|
|
|
if isinstance(key, basestring)}
|
2019-03-08 13:42:26 +03:00
|
|
|
if "OP" not in spec:
|
2019-01-21 15:23:15 +03:00
|
|
|
return (ONE,)
|
2019-03-08 13:42:26 +03:00
|
|
|
elif spec["OP"] in lookup:
|
|
|
|
return lookup[spec["OP"]]
|
2019-01-21 15:23:15 +03:00
|
|
|
else:
|
2019-03-08 13:42:26 +03:00
|
|
|
keys = ", ".join(lookup.keys())
|
2019-08-21 15:00:37 +03:00
|
|
|
raise ValueError(Errors.E011.format(op=spec["OP"], opts=keys))
|
2019-01-21 15:23:15 +03:00
|
|
|
|
|
|
|
|
|
|
|
def _get_extensions(spec, string_store, name2index):
|
|
|
|
attr_values = []
|
2019-08-21 15:00:37 +03:00
|
|
|
if not isinstance(spec.get("_", {}), dict):
|
|
|
|
raise ValueError(Errors.E154.format())
|
2019-03-08 13:42:26 +03:00
|
|
|
for name, value in spec.get("_", {}).items():
|
2019-01-21 15:23:15 +03:00
|
|
|
if isinstance(value, dict):
|
|
|
|
# Handle predicates (e.g. "IN", in the extra_predicates, not here.
|
|
|
|
continue
|
|
|
|
if isinstance(value, basestring):
|
|
|
|
value = string_store.add(value)
|
|
|
|
if name not in name2index:
|
|
|
|
name2index[name] = len(name2index)
|
|
|
|
attr_values.append((name2index[name], value))
|
|
|
|
return attr_values
|