explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-08-08 06:04:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

Another try at a cross-platform quoting test

Browse Source
This commit is contained in:
Paul O'Leary McCann 2022-08-26 13:11:28 +09:00
parent eb697d8371
commit 03e8b7f9c0
1 changed files with 28 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
spacy/tests/test_cli.py
View File

@ -26,6 +26,7 @@ from spacy.cli.init_config import RECOMMENDATIONS, init_config, fill_config
from spacy.cli.package import get_third_party_dependencies from spacy.cli.package import get_third_party_dependencies
from spacy.cli.package import _is_permitted_package_name from spacy.cli.package import _is_permitted_package_name
from spacy.cli.validate import get_model_pkgs from spacy.cli.validate import get_model_pkgs
from spacy.compat import is_windows
from spacy.lang.en import English from spacy.lang.en import English
from spacy.lang.nl import Dutch from spacy.lang.nl import Dutch
from spacy.language import Language from spacy.language import Language
@ -858,7 +859,31 @@ def test_span_length_freq_dist_output_must_be_correct():
assert list(span_freqs.keys()) == [3, 1, 4, 5, 2] assert list(span_freqs.keys()) == [3, 1, 4, 5, 2]
def test_shell_quoting(): def test_shell_quoting(tmp_path):
# simple quoted shell commands should run on any platform # simple quoted shell commands should run on any platform
ret = run_command('bash -c "echo ok"') # because mkdir is one of the few cross-platform commands,
assert ret.returncode == 0 # we'll work in a temp dir (pytest global fixture)
cwd = os.getcwd()
os.chdir(tmp_path)
try:
ret = run_command('mkdir "a b"')
assert ret.returncode == 0
# If things are working correctly, "a b"/c and "a b/c" should evaluate
# to the same directory. If they are working incorrectly, these could
# be treated differently.
# the slash here also works as a directory separator on Windows,
# for these commands at least.
ret = run_command('mkdir "a b"/c')
assert ret.returncode == 0
ls_cmd = "dir" if is_windows else "ls"
ret = run_command(f'{ls_cmd} "a b/c"')
assert ret.returncode == 0
# since this is a temp dir, we don't have to delete it explicitly
except:
# we failed, so make sure the test fails.
raise
finally:
# restore the original cwd so other tests are unaffected
os.chdir(cwd)