explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2024-09-21 11:29:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3853, and add warning

Browse Source
This commit is contained in:
Matthew Honnibal 2019-07-11 14:46:29 +02:00
parent 7369949d2e
commit 09dc01a426
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
spacy/_ml.py
View File

@ -24,7 +24,7 @@ from thinc.neural._classes.affine import _set_dimensions_if_needed
import thinc.extra.load_nlp import thinc.extra.load_nlp
from .attrs import ID, ORTH, LOWER, NORM, PREFIX, SUFFIX, SHAPE from .attrs import ID, ORTH, LOWER, NORM, PREFIX, SUFFIX, SHAPE
from .errors import Errors from .errors import Errors, user_warning, Warnings
from . import util from . import util
try: try:
@ -302,10 +302,13 @@ def link_vectors_to_models(vocab):
key = (ops.device, vectors.name) key = (ops.device, vectors.name)
if key in thinc.extra.load_nlp.VECTORS: if key in thinc.extra.load_nlp.VECTORS:
if thinc.extra.load_nlp.VECTORS[key].shape != data.shape: if thinc.extra.load_nlp.VECTORS[key].shape != data.shape:
print( # This is a hack to avoid the problem in #3853. Maybe we should
"Warning: Registering vectors data under the same ID as " # print a warning as well?
"existing vectors, and the new vectors data seems different. " old_name = vectors.name
"This might lead to incorrect results. See Issue #3853") new_name = vectors.name + "_%d" % data.shape[0]
user_warning(Warnings.W019.format(old=old_name, new=new_name))
vectors.name = new_name
key = (ops.device, vectors.name)
thinc.extra.load_nlp.VECTORS[key] = data thinc.extra.load_nlp.VECTORS[key] = data