From 13481fbcc2b4e35cf26de356e5cd3c6b49a2c93f Mon Sep 17 00:00:00 2001 From: Paul O'Leary McCann Date: Fri, 13 May 2022 19:29:28 +0900 Subject: [PATCH] Remove unused param, add TODOs about typing --- spacy/ml/models/coref.py | 3 +-- spacy/ml/models/span_predictor.py | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spacy/ml/models/coref.py b/spacy/ml/models/coref.py index 24b5500a2..cfbe83a7a 100644 --- a/spacy/ml/models/coref.py +++ b/spacy/ml/models/coref.py @@ -22,9 +22,8 @@ def build_wl_coref_model( rough_k: int = 50, # TODO is this not a training loop setting? a_scoring_batch_size: int = 512, - # span predictor embeddings - sp_embedding_size: int = 64, ): + # TODO add model return types # TODO fix this try: dim = tok2vec.get_dim("nO") diff --git a/spacy/ml/models/span_predictor.py b/spacy/ml/models/span_predictor.py index b990b4019..c5cbb328c 100644 --- a/spacy/ml/models/span_predictor.py +++ b/spacy/ml/models/span_predictor.py @@ -17,6 +17,7 @@ def build_span_predictor( hidden_size: int = 1024, dist_emb_size: int = 64, ): + # TODO add model return types # TODO fix this try: dim = tok2vec.get_dim("nO")