From 13d562e1a4b38c44bab39a060f17e0b36a3b56fb Mon Sep 17 00:00:00 2001 From: Alex Villarreal Date: Wed, 2 May 2018 03:16:05 -0500 Subject: [PATCH] Fix code sample for Doc.set_extension (#2282) * Fix code sample for `set_extension` The previous sample code for `set_extension` fails the assertion at the end, because `city_getter` it checked if the whole document text matches any of the city names. Now it checks if any of the city names is contained in the document text. * Contributor agreement --- .github/contributors/alexvy86.md | 87 ++++++++++++++++++++++++++++++++ website/api/doc.jade | 2 +- 2 files changed, 88 insertions(+), 1 deletion(-) create mode 100644 .github/contributors/alexvy86.md diff --git a/.github/contributors/alexvy86.md b/.github/contributors/alexvy86.md new file mode 100644 index 000000000..c8e9ce79f --- /dev/null +++ b/.github/contributors/alexvy86.md @@ -0,0 +1,87 @@ +## Contributor Agreement + +1. The term "contribution" or "contributed materials" means any source code, +object code, patch, tool, sample, graphic, specification, manual, +documentation, or any other material posted or submitted by you to the project. + +2. With respect to any worldwide copyrights, or copyright applications and +registrations, in your contribution: + + * you hereby assign to us joint ownership, and to the extent that such + assignment is or becomes invalid, ineffective or unenforceable, you hereby + grant to us a perpetual, irrevocable, non-exclusive, worldwide, no-charge, + royalty-free, unrestricted license to exercise all rights under those + copyrights. This includes, at our option, the right to sublicense these same + rights to third parties through multiple levels of sublicensees or other + licensing arrangements; + + * you agree that each of us can do all things in relation to your + contribution as if each of us were the sole owners, and if one of us makes + a derivative work of your contribution, the one who makes the derivative + work (or has it made will be the sole owner of that derivative work; + + * you agree that you will not assert any moral rights in your contribution + against us, our licensees or transferees; + + * you agree that we may register a copyright in your contribution and + exercise all ownership rights associated with it; and + + * you agree that neither of us has any duty to consult with, obtain the + consent of, pay or render an accounting to the other for any use or + distribution of your contribution. + +3. With respect to any patents you own, or that you can license without payment +to any third party, you hereby grant to us a perpetual, irrevocable, +non-exclusive, worldwide, no-charge, royalty-free license to: + + * make, have made, use, sell, offer to sell, import, and otherwise transfer + your contribution in whole or in part, alone or in combination with or + included in any product, work or materials arising out of the project to + which your contribution was submitted, and + + * at our option, to sublicense these same rights to third parties through + multiple levels of sublicensees or other licensing arrangements. + +4. Except as set out above, you keep all right, title, and interest in your +contribution. The rights that you grant to us under these terms are effective +on the date you first submitted a contribution to us, even if your submission +took place before the date you sign these terms. + +5. You covenant, represent, warrant and agree that: + + * Each contribution that you submit is and shall be an original work of + authorship and you can legally grant the rights set out in this SCA; + + * to the best of your knowledge, each contribution will not violate any + third party's copyrights, trademarks, patents, or other intellectual + property rights; and + + * each contribution shall be in compliance with U.S. export control laws and + other applicable export and import laws. You agree to notify us if you + become aware of any circumstance which would make any of the foregoing + representations inaccurate in any respect. We may publicly disclose your + participation in the project, including the fact that you have signed the SCA. + +6. This SCA is governed by the laws of the State of California and applicable +U.S. Federal law. Any choice of law rules will not apply. + +7. Please place an “x” on one of the applicable statement below. Please do NOT +mark both statements: + + * [x] I am signing on behalf of myself as an individual and no other person + or entity, including my employer, has or will have rights with respect to my + contributions. + + * [ ] I am signing on behalf of my employer or a legal entity and I have the + actual authority to contractually bind that entity. + +## Contributor Details + +| Field | Entry | +|------------------------------- | -------------------- | +| Name | Alejandro Villarreal | +| Company name (if applicable) | | +| Title or role (if applicable) | | +| Date | 2018-05-01 | +| GitHub username | alexvy86 | +| Website (optional) | | diff --git a/website/api/doc.jade b/website/api/doc.jade index 9a0b3253d..5a4d39057 100644 --- a/website/api/doc.jade +++ b/website/api/doc.jade @@ -149,7 +149,7 @@ p +aside-code("Example"). from spacy.tokens import Doc - city_getter = lambda doc: doc.text in ('New York', 'Paris', 'Berlin') + city_getter = lambda doc: any(city in doc.text for city in ('New York', 'Paris', 'Berlin')) Doc.set_extension('has_city', getter=city_getter) doc = nlp(u'I like New York') assert doc._.has_city