From 178c14761221db06bc2174e5dac6e94abf5e5c7d Mon Sep 17 00:00:00 2001 From: Ines Montani Date: Thu, 12 Jan 2017 01:06:36 +0100 Subject: [PATCH] Modernise nonprojectivity tests and don't depend on models --- spacy/tests/parser/test_nonproj.py | 223 +++++++++++++++-------------- 1 file changed, 113 insertions(+), 110 deletions(-) diff --git a/spacy/tests/parser/test_nonproj.py b/spacy/tests/parser/test_nonproj.py index 337004251..8161d6fc3 100644 --- a/spacy/tests/parser/test_nonproj.py +++ b/spacy/tests/parser/test_nonproj.py @@ -1,137 +1,140 @@ +# coding: utf-8 from __future__ import unicode_literals + +from ...syntax.nonproj import ancestors, contains_cycle, is_nonproj_arc +from ...syntax.nonproj import is_nonproj_tree, PseudoProjectivity +from ...attrs import DEP, HEAD +from ..util import get_doc + import pytest -from spacy.attrs import DEP, HEAD -import numpy -from spacy.syntax.nonproj import ancestors, contains_cycle, is_nonproj_arc, is_nonproj_tree, PseudoProjectivity +@pytest.fixture +def tree(): + return [1, 2, 2, 4, 5, 2, 2] -def test_ancestors(): - tree = [1,2,2,4,5,2,2] - cyclic_tree = [1,2,2,4,5,3,2] - partial_tree = [1,2,2,4,5,None,2] - multirooted_tree = [3,2,0,3,3,7,7,3,7,10,7,10,11,12,18,16,18,17,12,3] - assert([ a for a in ancestors(3,tree) ] == [4,5,2]) - assert([ a for a in ancestors(3,cyclic_tree) ] == [4,5,3,4,5,3,4]) - assert([ a for a in ancestors(3,partial_tree) ] == [4,5,None]) - assert([ a for a in ancestors(17,multirooted_tree) ] == []) +@pytest.fixture +def cyclic_tree(): + return [1, 2, 2, 4, 5, 3, 2] -def test_contains_cycle(): - tree = [1,2,2,4,5,2,2] - cyclic_tree = [1,2,2,4,5,3,2] - partial_tree = [1,2,2,4,5,None,2] - multirooted_tree = [3,2,0,3,3,7,7,3,7,10,7,10,11,12,18,16,18,17,12,3] - assert(contains_cycle(tree) == None) - assert(contains_cycle(cyclic_tree) == set([3,4,5])) - assert(contains_cycle(partial_tree) == None) - assert(contains_cycle(multirooted_tree) == None) +@pytest.fixture +def partial_tree(): + return [1, 2, 2, 4, 5, None, 7, 4, 2] -def test_is_nonproj_arc(): - nonproj_tree = [1,2,2,4,5,2,7,4,2] - partial_tree = [1,2,2,4,5,None,7,4,2] - multirooted_tree = [3,2,0,3,3,7,7,3,7,10,7,10,11,12,18,16,18,17,12,3] - assert(is_nonproj_arc(0,nonproj_tree) == False) - assert(is_nonproj_arc(1,nonproj_tree) == False) - assert(is_nonproj_arc(2,nonproj_tree) == False) - assert(is_nonproj_arc(3,nonproj_tree) == False) - assert(is_nonproj_arc(4,nonproj_tree) == False) - assert(is_nonproj_arc(5,nonproj_tree) == False) - assert(is_nonproj_arc(6,nonproj_tree) == False) - assert(is_nonproj_arc(7,nonproj_tree) == True) - assert(is_nonproj_arc(8,nonproj_tree) == False) - assert(is_nonproj_arc(7,partial_tree) == False) - assert(is_nonproj_arc(17,multirooted_tree) == False) - assert(is_nonproj_arc(16,multirooted_tree) == True) +@pytest.fixture +def nonproj_tree(): + return [1, 2, 2, 4, 5, 2, 7, 4, 2] -def test_is_nonproj_tree(): - proj_tree = [1,2,2,4,5,2,7,5,2] - nonproj_tree = [1,2,2,4,5,2,7,4,2] - partial_tree = [1,2,2,4,5,None,7,4,2] - multirooted_tree = [3,2,0,3,3,7,7,3,7,10,7,10,11,12,18,16,18,17,12,3] - assert(is_nonproj_tree(proj_tree) == False) - assert(is_nonproj_tree(nonproj_tree) == True) - assert(is_nonproj_tree(partial_tree) == False) - assert(is_nonproj_tree(multirooted_tree) == True) +@pytest.fixture +def proj_tree(): + return [1, 2, 2, 4, 5, 2, 7, 5, 2] + +@pytest.fixture +def multirooted_tree(): + return [3, 2, 0, 3, 3, 7, 7, 3, 7, 10, 7, 10, 11, 12, 18, 16, 18, 17, 12, 3] -def deprojectivize(proj_heads, deco_labels, EN): - slen = len(proj_heads) - sent = EN.tokenizer.tokens_from_list(['whatever'] * slen) - rel_proj_heads = [ head-i for i,head in enumerate(proj_heads) ] - labelids = [ EN.vocab.strings[label] for label in deco_labels ] - pairs = list(zip(rel_proj_heads,labelids)) - parse = numpy.asarray(pairs, dtype=numpy.int32) - sent.from_array([HEAD,DEP],parse) - PseudoProjectivity.deprojectivize(sent) - parse = sent.to_array([HEAD,DEP]) - deproj_heads = [ i+head for i,head in enumerate(parse[:,0]) ] - undeco_labels = [ EN.vocab.strings[int(labelid)] for labelid in parse[:,1] ] - return deproj_heads, undeco_labels +def test_parser_ancestors(tree, cyclic_tree, partial_tree, multirooted_tree): + assert([a for a in ancestors(3, tree)] == [4, 5, 2]) + assert([a for a in ancestors(3, cyclic_tree)] == [4, 5, 3, 4, 5, 3, 4]) + assert([a for a in ancestors(3, partial_tree)] == [4, 5, None]) + assert([a for a in ancestors(17, multirooted_tree)] == []) -@pytest.mark.models -def test_pseudoprojectivity(EN): - tree = [1,2,2] - nonproj_tree = [1,2,2,4,5,2,7,4,2] - labels = ['det','nsubj','root','det','dobj','aux','nsubj','acl','punct'] - nonproj_tree2 = [9,1,3,1,5,6,9,8,6,1,6,12,13,10,1] - labels2 = ['advmod','root','det','nsubj','advmod','det','dobj','det','nmod','aux','nmod','advmod','det','amod','punct'] - - assert(PseudoProjectivity.decompose('X||Y') == ('X','Y')) - assert(PseudoProjectivity.decompose('X') == ('X','')) - - assert(PseudoProjectivity.is_decorated('X||Y') == True) - assert(PseudoProjectivity.is_decorated('X') == False) - - PseudoProjectivity._lift(0,tree) - assert(tree == [2,2,2]) - - np_arc = PseudoProjectivity._get_smallest_nonproj_arc(nonproj_tree) - assert(np_arc == 7) - - np_arc = PseudoProjectivity._get_smallest_nonproj_arc(nonproj_tree2) - assert(np_arc == 10) - - proj_heads, deco_labels = PseudoProjectivity.projectivize(nonproj_tree,labels) - assert(proj_heads == [1,2,2,4,5,2,7,5,2]) - assert(deco_labels == ['det','nsubj','root','det','dobj','aux','nsubj','acl||dobj','punct']) - deproj_heads, undeco_labels = deprojectivize(proj_heads,deco_labels,EN) - assert(deproj_heads == nonproj_tree) - assert(undeco_labels == labels) - - proj_heads, deco_labels = PseudoProjectivity.projectivize(nonproj_tree2,labels2) - assert(proj_heads == [1,1,3,1,5,6,9,8,6,1,9,12,13,10,1]) - assert(deco_labels == ['advmod||aux','root','det','nsubj','advmod','det','dobj','det','nmod','aux','nmod||dobj','advmod','det','amod','punct']) - deproj_heads, undeco_labels = deprojectivize(proj_heads,deco_labels,EN) - assert(deproj_heads == nonproj_tree2) - assert(undeco_labels == labels2) - - # if decoration is wrong such that there is no head with the desired label - # the structure is kept and the label is undecorated - proj_heads = [1,2,2,4,5,2,7,5,2] - deco_labels = ['det','nsubj','root','det','dobj','aux','nsubj','acl||iobj','punct'] - deproj_heads, undeco_labels = deprojectivize(proj_heads,deco_labels,EN) - assert(deproj_heads == proj_heads) - assert(undeco_labels == ['det','nsubj','root','det','dobj','aux','nsubj','acl','punct']) - - # if there are two potential new heads, the first one is chosen even if it's wrong - proj_heads = [1,1,3,1,5,6,9,8,6,1,9,12,13,10,1] - deco_labels = ['advmod||aux','root','det','aux','advmod','det','dobj','det','nmod','aux','nmod||dobj','advmod','det','amod','punct'] - deproj_heads, undeco_labels = deprojectivize(proj_heads,deco_labels,EN) - assert(deproj_heads == [3,1,3,1,5,6,9,8,6,1,6,12,13,10,1]) - assert(undeco_labels == ['advmod','root','det','aux','advmod','det','dobj','det','nmod','aux','nmod','advmod','det','amod','punct']) +def test_parser_contains_cycle(tree, cyclic_tree, partial_tree, multirooted_tree): + assert(contains_cycle(tree) == None) + assert(contains_cycle(cyclic_tree) == set([3, 4, 5])) + assert(contains_cycle(partial_tree) == None) + assert(contains_cycle(multirooted_tree) == None) +def test_parser_is_nonproj_arc(nonproj_tree, partial_tree, multirooted_tree): + assert(is_nonproj_arc(0, nonproj_tree) == False) + assert(is_nonproj_arc(1, nonproj_tree) == False) + assert(is_nonproj_arc(2, nonproj_tree) == False) + assert(is_nonproj_arc(3, nonproj_tree) == False) + assert(is_nonproj_arc(4, nonproj_tree) == False) + assert(is_nonproj_arc(5, nonproj_tree) == False) + assert(is_nonproj_arc(6, nonproj_tree) == False) + assert(is_nonproj_arc(7, nonproj_tree) == True) + assert(is_nonproj_arc(8, nonproj_tree) == False) + assert(is_nonproj_arc(7, partial_tree) == False) + assert(is_nonproj_arc(17, multirooted_tree) == False) + assert(is_nonproj_arc(16, multirooted_tree) == True) +def test_parser_is_nonproj_tree(proj_tree, nonproj_tree, partial_tree, multirooted_tree): + assert(is_nonproj_tree(proj_tree) == False) + assert(is_nonproj_tree(nonproj_tree) == True) + assert(is_nonproj_tree(partial_tree) == False) + assert(is_nonproj_tree(multirooted_tree) == True) +def test_parser_pseudoprojectivity(en_tokenizer): + def deprojectivize(proj_heads, deco_labels): + tokens = en_tokenizer('whatever ' * len(proj_heads)) + rel_proj_heads = [head-i for i, head in enumerate(proj_heads)] + doc = get_doc(tokens.vocab, [t.text for t in tokens], deps=deco_labels, heads=rel_proj_heads) + PseudoProjectivity.deprojectivize(doc) + return [t.head.i for t in doc], [token.dep_ for token in doc] + tree = [1, 2, 2] + nonproj_tree = [1, 2, 2, 4, 5, 2, 7, 4, 2] + nonproj_tree2 = [9, 1, 3, 1, 5, 6, 9, 8, 6, 1, 6, 12, 13, 10, 1] + labels = ['det', 'nsubj', 'root', 'det', 'dobj', 'aux', 'nsubj', 'acl', 'punct'] + labels2 = ['advmod', 'root', 'det', 'nsubj', 'advmod', 'det', 'dobj', 'det', 'nmod', 'aux', 'nmod', 'advmod', 'det', 'amod', 'punct'] + assert(PseudoProjectivity.decompose('X||Y') == ('X','Y')) + assert(PseudoProjectivity.decompose('X') == ('X','')) + assert(PseudoProjectivity.is_decorated('X||Y') == True) + assert(PseudoProjectivity.is_decorated('X') == False) + PseudoProjectivity._lift(0, tree) + assert(tree == [2, 2, 2]) + assert(PseudoProjectivity._get_smallest_nonproj_arc(nonproj_tree) == 7) + assert(PseudoProjectivity._get_smallest_nonproj_arc(nonproj_tree2) == 10) + proj_heads, deco_labels = PseudoProjectivity.projectivize(nonproj_tree, labels) + assert(proj_heads == [1, 2, 2, 4, 5, 2, 7, 5, 2]) + assert(deco_labels == ['det', 'nsubj', 'root', 'det', 'dobj', 'aux', + 'nsubj', 'acl||dobj', 'punct']) + deproj_heads, undeco_labels = deprojectivize(proj_heads, deco_labels) + assert(deproj_heads == nonproj_tree) + assert(undeco_labels == labels) + proj_heads, deco_labels = PseudoProjectivity.projectivize(nonproj_tree2, labels2) + assert(proj_heads == [1, 1, 3, 1, 5, 6, 9, 8, 6, 1, 9, 12, 13, 10, 1]) + assert(deco_labels == ['advmod||aux', 'root', 'det', 'nsubj', 'advmod', + 'det', 'dobj', 'det', 'nmod', 'aux', 'nmod||dobj', + 'advmod', 'det', 'amod', 'punct']) + deproj_heads, undeco_labels = deprojectivize(proj_heads, deco_labels) + assert(deproj_heads == nonproj_tree2) + assert(undeco_labels == labels2) + + # if decoration is wrong such that there is no head with the desired label + # the structure is kept and the label is undecorated + proj_heads = [1, 2, 2, 4, 5, 2, 7, 5, 2] + deco_labels = ['det', 'nsubj', 'root', 'det', 'dobj', 'aux', 'nsubj', + 'acl||iobj', 'punct'] + + deproj_heads, undeco_labels = deprojectivize(proj_heads, deco_labels) + assert(deproj_heads == proj_heads) + assert(undeco_labels == ['det', 'nsubj', 'root', 'det', 'dobj', 'aux', + 'nsubj', 'acl', 'punct']) + + # if there are two potential new heads, the first one is chosen even if + # it's wrong + proj_heads = [1, 1, 3, 1, 5, 6, 9, 8, 6, 1, 9, 12, 13, 10, 1] + deco_labels = ['advmod||aux', 'root', 'det', 'aux', 'advmod', 'det', + 'dobj', 'det', 'nmod', 'aux', 'nmod||dobj', 'advmod', + 'det', 'amod', 'punct'] + + deproj_heads, undeco_labels = deprojectivize(proj_heads, deco_labels) + assert(deproj_heads == [3, 1, 3, 1, 5, 6, 9, 8, 6, 1, 6, 12, 13, 10, 1]) + assert(undeco_labels == ['advmod', 'root', 'det', 'aux', 'advmod', 'det', + 'dobj', 'det', 'nmod', 'aux', 'nmod', 'advmod', + 'det', 'amod', 'punct'])