explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-11-04 09:57:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use unicode paths on Windows/Python 2 and catch other errors (resolves #970)

Browse Source 
try/except here is quite dirty, but it'll at least make sure users see
an error message that explains what's going on
This commit is contained in:
ines 2017-04-10 17:49:49 +02:00
parent ecfbc0b621
commit 1b92c8d5d5
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
spacy/cli/link.py
View File

@ -46,8 +46,18 @@ def symlink(model_path, link_name, force):
# Add workaround for Python 2 on Windows (see issue #909) # Add workaround for Python 2 on Windows (see issue #909)
if util.is_python2() and util.is_windows(): if util.is_python2() and util.is_windows():
import subprocess import subprocess
command = ['mklink', '/d', link_path, model_path] command = ['mklink', '/d', unicode(link_path), unicode(model_path)]
try:
subprocess.call(command, shell=True) subprocess.call(command, shell=True)
except:
# This is quite dirty, but just making sure other Windows-specific
# errors are caught so users at least see a proper error message.
util.sys_exit(
"Creating a symlink in spacy/data failed. You can still import "
"the model as a Python package and call its load() method, or "
"create the symlink manually:",
"{a} --> {b}".format(a=unicode(model_path), b=unicode(link_path)),
title="Error: Couldn't link model to '{l}'".format(l=link_name))
else: else:
link_path.symlink_to(model_path) link_path.symlink_to(model_path)