From 1da14748dbf8acb6861b688e7ba7b7b55690a29b Mon Sep 17 00:00:00 2001 From: thomashacker Date: Mon, 27 Mar 2023 14:05:38 +0200 Subject: [PATCH] Add unit test assertions --- spacy/tests/training/test_pretraining.py | 20 ++------------------ 1 file changed, 2 insertions(+), 18 deletions(-) diff --git a/spacy/tests/training/test_pretraining.py b/spacy/tests/training/test_pretraining.py index 47aee0796..7e15810d5 100644 --- a/spacy/tests/training/test_pretraining.py +++ b/spacy/tests/training/test_pretraining.py @@ -164,24 +164,6 @@ def test_pretraining_default(): assert "PretrainCharacters" in filled["pretraining"]["objective"]["@architectures"] -@pytest.mark.parametrize("objective", CHAR_OBJECTIVES) -def test_pretraining_last_model(objective): - """Test that pretraining works with the character objective""" - config = Config().from_str(pretrain_string_listener) - config["pretraining"]["objective"] = objective - nlp = util.load_model_from_config(config, auto_fill=True, validate=False) - filled = nlp.config - pretrain_config = util.load_config(DEFAULT_CONFIG_PRETRAIN_PATH) - filled = pretrain_config.merge(filled) - with make_tempdir() as tmp_dir: - file_path = write_sample_jsonl(tmp_dir) - filled["paths"]["raw_text"] = file_path - filled = filled.interpolate() - assert filled["pretraining"]["component"] == "tok2vec" - pretrain(filled, tmp_dir) - assert Path(tmp_dir / "model_last.bin").exists() - - @pytest.mark.parametrize("objective", CHAR_OBJECTIVES) def test_pretraining_tok2vec_characters(objective): """Test that pretraining works with the character objective""" @@ -199,6 +181,7 @@ def test_pretraining_tok2vec_characters(objective): pretrain(filled, tmp_dir) assert Path(tmp_dir / "model0.bin").exists() assert Path(tmp_dir / "model4.bin").exists() + assert Path(tmp_dir / "model_last.bin").exists() assert not Path(tmp_dir / "model5.bin").exists() @@ -255,6 +238,7 @@ def test_pretraining_tagger_tok2vec(config): pretrain(filled, tmp_dir) assert Path(tmp_dir / "model0.bin").exists() assert Path(tmp_dir / "model4.bin").exists() + assert Path(tmp_dir / "model_last.bin").exists() assert not Path(tmp_dir / "model5.bin").exists()