This commit is contained in:
Adriane Boyd 2022-11-03 12:43:50 +01:00
parent 0c51c2c698
commit 25d56ce0f7

View File

@ -85,24 +85,25 @@ class RemoteStorage:
# This requires that the path is added correctly, relative
# to root. This is how we set things up in push()
def is_within_directory(directory, target):
abs_directory = os.path.abspath(directory)
abs_target = os.path.abspath(target)
prefix = os.path.commonprefix([abs_directory, abs_target])
return prefix == abs_directory
def safe_extract(tar, path=".", members=None, *, numeric_owner=False):
def safe_extract(
tar, path=".", members=None, *, numeric_owner=False
):
for member in tar.getmembers():
member_path = os.path.join(path, member.name)
if not is_within_directory(path, member_path):
raise Exception("Attempted Path Traversal in Tar File")
tar.extractall(path, members, numeric_owner=numeric_owner)
tar.extractall(path, members, numeric_owner=numeric_owner)
safe_extract(tar_file, self.root)
return url