explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-06-01 19:53:06 +03:00
Code Issues Packages Projects Releases Wiki Activity

Fix overwriting of existing symlinks

Browse Source 
Check for is_symlink() to also overwrite invalid and outdated symlinks. Also show better error message if link path exists but is not symlink (i.e. file or directory).
This commit is contained in:
ines 2018-01-03 17:39:36 +01:00
parent 8ba0dfd017
commit 319d754309
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
spacy/cli/link.py
View File

@ -34,11 +34,18 @@ def link(cmd, origin, link_name, force=False, model_path=None):
"located here:", path2str(spacy_loc), exits=1, "located here:", path2str(spacy_loc), exits=1,
title="Can't find the spaCy data path to create model symlink") title="Can't find the spaCy data path to create model symlink")
link_path = util.get_data_path() / link_name link_path = util.get_data_path() / link_name
if link_path.exists() and not force: if link_path.is_symlink() and not force:
prints("To overwrite an existing link, use the --force flag.", prints("To overwrite an existing link, use the --force flag.",
title="Link %s already exists" % link_name, exits=1) title="Link %s already exists" % link_name, exits=1)
elif link_path.exists(): elif link_path.is_symlink(): # does a symlink exist?
# NB: It's important to check for is_symlink here and not for exists,
# because invalid/outdated symlinks would return False otherwise.
link_path.unlink() link_path.unlink()
elif link_path.exists(): # does it exist otherwise?
# NB: Check this last because valid symlinks also "exist".
prints("This can happen if your data directory contains a directory "
"or file of the same name.", link_path,
title="Can't overwrite symlink %s" % link_name, exits=1)
try: try:
symlink_to(link_path, model_path) symlink_to(link_path, model_path)
except: except: