explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-08-02 19:30:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

Use importlib instead of meta.json

Browse Source
This commit is contained in:
Paul O'Leary McCann 2023-01-26 19:32:25 +09:00
parent ed47384da1
commit 320a966bd1
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spacy/cli/download.py
View File

@ -3,12 +3,12 @@ import requests
import sys import sys
from wasabi import msg from wasabi import msg
import typer import typer
import srsly import importlib.metadata as importlib_metadata
from ._util import app, Arg, Opt, WHEEL_SUFFIX, SDIST_SUFFIX from ._util import app, Arg, Opt, WHEEL_SUFFIX, SDIST_SUFFIX
from .. import about from .. import about
from ..util import is_package, get_minor_version, run_command from ..util import is_package, get_minor_version, run_command
from ..util import is_prerelease_version, get_installed_models, get_package_path from ..util import is_prerelease_version, get_installed_models
@app.command( @app.command(
@ -67,10 +67,8 @@ def download(
# If we already have this version installed, skip downloading # If we already have this version installed, skip downloading
installed = get_installed_models() installed = get_installed_models()
if model_name in installed: if model_name in installed:
model_path = get_package_path(model_name) installed_version = importlib_metadata.version(model_name)
meta_path = model_path / "meta.json" if installed_version == version:
meta = srsly.read_json(meta_path)
if meta["version"] == version:
msg.warn(f"{model_name} v{version} already installed, skipping") msg.warn(f"{model_name} v{version} already installed, skipping")
return return