Don't print in parse_package_meta and accept on_erro callback instead

TODO: log warning for missing meta data in spacy.link, as this affects
the Language class returned by spacy.load()
This commit is contained in:
ines 2017-03-16 20:34:50 +01:00
parent d8c984b65e
commit 3d484c3faf

View File

@ -149,11 +149,10 @@ def check_renamed_kwargs(renamed, kwargs):
raise TypeError("Keyword argument %s now renamed to %s" % (old, new))
def parse_package_meta(package_path, package):
def parse_package_meta(package_path, package, on_error=False):
location = os.path.join(str(package_path), package, 'meta.json')
if not os.path.isfile(location):
print_msg("'{p}' doesn't seem to be a valid model package.".format(p=package),
title="No meta.json found")
if not os.path.isfile(location) and on_error:
on_error()
else:
with io.open(location, encoding='utf8') as f:
meta = json.load(f)