From 4a9dc00d86679489d7051ed442fa73fd00043b77 Mon Sep 17 00:00:00 2001 From: Paul O'Leary McCann Date: Wed, 14 Jul 2021 18:36:18 +0900 Subject: [PATCH] Use relative indices for mentions Was using batch absolute indices to manage mentions, but extract_spans expects doc-relative ones. --- spacy/ml/models/coref.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/spacy/ml/models/coref.py b/spacy/ml/models/coref.py index 52a549509..bcbed888d 100644 --- a/spacy/ml/models/coref.py +++ b/spacy/ml/models/coref.py @@ -153,7 +153,6 @@ def span_embeddings_forward( get_mentions = model.attrs["get_mentions"] max_span_width = model.attrs["max_span_width"] mentions = ops.alloc2i(0, 2) - total_length = 0 docmenlens = [] # number of mentions per doc for doc in docs: @@ -161,8 +160,7 @@ def span_embeddings_forward( docmenlens.append(len(starts)) cments = ops.asarray2i([starts, ends]).transpose() - mentions = xp.concatenate((mentions, cments + total_length)) - total_length += len(doc) + mentions = xp.concatenate( (mentions, cments) ) # TODO support attention here tokvecs = xp.concatenate(tokvecs)