explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-08-08 06:04:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

Remove use of split_command in dvc

Browse Source 
In order to be safe on Windows, this uses string concatenation instead
of relying on shlex.split to create a command list.
This commit is contained in:
Paul O'Leary McCann 2022-09-02 12:51:26 +09:00
parent 03e8b7f9c0
commit 5058607896
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spacy/cli/project/dvc.py
View File

@ -7,7 +7,7 @@ from wasabi import msg
from .._util import PROJECT_FILE, load_project_config, get_hash, project_cli from .._util import PROJECT_FILE, load_project_config, get_hash, project_cli
from .._util import Arg, Opt, NAME, COMMAND from .._util import Arg, Opt, NAME, COMMAND
from ...util import working_dir, split_command, join_command, run_command from ...util import working_dir, join_command, run_command
from ...util import SimpleFrozenList from ...util import SimpleFrozenList
@ -144,12 +144,11 @@ def run_dvc_commands(
command-line setting while avoiding lots of nested conditionals. command-line setting while avoiding lots of nested conditionals.
""" """
for c in commands: for c in commands:
command = split_command(c) dvc_command = "dvc " + c
dvc_command = ["dvc", *command]
# Add the flags if they are set to True # Add the flags if they are set to True
for flag, is_active in flags.items(): for flag, is_active in flags.items():
if is_active: if is_active:
dvc_command.append(flag) dvc_command += " " + flag
run_command(dvc_command) run_command(dvc_command)