diff --git a/setup.py b/setup.py index 243554c7a..79bdcba8d 100755 --- a/setup.py +++ b/setup.py @@ -30,7 +30,6 @@ MOD_NAMES = [ "spacy.lexeme", "spacy.vocab", "spacy.attrs", - "spacy.kb.candidate", "spacy.kb.kb", "spacy.kb.kb_in_memory", "spacy.ml.parser_model", diff --git a/spacy/kb/candidate.py b/spacy/kb/candidate.py index b121974f8..190792fbe 100644 --- a/spacy/kb/candidate.py +++ b/spacy/kb/candidate.py @@ -47,11 +47,6 @@ class BaseCandidate(abc.ABC): class Candidate(BaseCandidate): """`Candidate` for InMemoryLookupKBCandidate.""" - # todo - # - glue together - # - is candidate definition necessary for EL? as long as interface fulfills requirements, this shouldn't matter. - # otherwise incorporate new argument. - # - fix test failures (100% backwards-compatible should be possible after changing EntityLinker) def __init__( self, retrieve_string_from_hash: Callable[[int], str], diff --git a/spacy/tests/pipeline/test_entity_linker.py b/spacy/tests/pipeline/test_entity_linker.py index c4cd411bb..7ef155bfb 100644 --- a/spacy/tests/pipeline/test_entity_linker.py +++ b/spacy/tests/pipeline/test_entity_linker.py @@ -496,8 +496,6 @@ def test_el_pipe_configuration(nlp): doc = nlp(text) assert doc[0].ent_kb_id_ == "NIL" assert doc[1].ent_kb_id_ == "" - # todo It's unclear why EL doesn't learn properly for this test anymore (scores are 0). Seemed to work before, but - # no relevant changes in EL code were made since these tests were added AFAIK (CG seems to work fine). assert doc[2].ent_kb_id_ in ("Q2", "Q3") # Replace the pipe with a new one with with a different candidate generator.