explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-08-04 12:20:20 +03:00
Code Issues Packages Projects Releases Wiki Activity

Test improvements from code review

Browse Source
This commit is contained in:
Daniël de Kok 2023-01-25 17:18:34 +01:00
parent d3bed2f128
commit 65e107f216
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spacy/tests/training/test_corpus.py
View File

@ -6,6 +6,7 @@ import tempfile
from spacy.lang.en import English from spacy.lang.en import English
from spacy.training import Example, PlainTextCorpus from spacy.training import Example, PlainTextCorpus
from spacy.util import make_tempdir
# Intentional newlines to check that they are skipped. # Intentional newlines to check that they are skipped.
PLAIN_TEXT_DOC = """ PLAIN_TEXT_DOC = """
@ -35,7 +36,8 @@ PLAIN_TEXT_DOC_TOKENIZED = [
] ]
@pytest.mark.parametrize("min_length, max_length", [(0, 0), (0, 5), (5, 0), (5, 5)]) @pytest.mark.parametrize("min_length", [0, 5])
@pytest.mark.parametrize("max_length", [0, 5])
def test_plain_text_reader(min_length, max_length): def test_plain_text_reader(min_length, max_length):
nlp = English() nlp = English()
with _string_to_tmp_file(PLAIN_TEXT_DOC) as file_path: with _string_to_tmp_file(PLAIN_TEXT_DOC) as file_path:
@ -56,10 +58,10 @@ def test_plain_text_reader(min_length, max_length):
@contextmanager @contextmanager
def _string_to_tmp_file(s: str) -> Generator[Path, None, None]: def _string_to_tmp_file(s: str) -> Generator[Path, None, None]:
with tempfile.TemporaryDirectory() as d: with make_tempdir() as d:
file_path = Path(d) / "string.txt" file_path = Path(d) / "string.txt"
with open(file_path, "wb") as f: with open(file_path, "w", encoding="utf-8") as f:
f.write(s.encode("utf-8")) f.write(s)
yield file_path yield file_path