From 685fff40cfb8987a1a07bb60fffea429ff929b98 Mon Sep 17 00:00:00 2001 From: Ines Montani Date: Wed, 20 Mar 2019 01:03:40 +0100 Subject: [PATCH] Revert "Add --always-link flag to cli.download (see #3435)" This reverts commit 583a56684317735d0946075d03b5bea42fc6d293. --- spacy/cli/download.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/spacy/cli/download.py b/spacy/cli/download.py index 1ebdb66b2..66a47823c 100644 --- a/spacy/cli/download.py +++ b/spacy/cli/download.py @@ -19,10 +19,9 @@ msg = Printer() @plac.annotations( model=("Model to download (shortcut or name)", "positional", None, str), direct=("Force direct download of name + version", "flag", "d", bool), - always_link=("Always create symlinks, even if not shortcut", "flag", "l", bool), - pip_args=("Additional arguments to be passed to `pip install` on model install"), + pip_args=("additional arguments to be passed to `pip install` on model install"), ) -def download(model, direct=False, always_link=False, *pip_args): +def download(model, direct=False, *pip_args): """ Download compatible model from default download path using pip. Model can be shortcut, model name or, if --direct flag is set, full model name @@ -49,7 +48,7 @@ def download(model, direct=False, always_link=False, *pip_args): # Only create symlink if the model is installed via a shortcut like 'en'. # There's no real advantage over an additional symlink for en_core_web_sm # and if anything, it's more error prone and causes more confusion. - if model in shortcuts or always_link: + if model in shortcuts: try: # Get package path here because link uses # pip.get_installed_distributions() to check if model is a