explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-01-26 17:24:41 +03:00
Code Issues Packages Projects Releases Wiki Activity

Check if the resume path points to a directory (#7919)

Browse Source 
This came up in #7878, but if --resume-path is a directory then loading
the weights will fail. On Linux this will give a straightforward error
message, but on Windows it gives "Permission Denied", which is
confusing.
This commit is contained in:
Paul O'Leary McCann 2021-04-28 16:17:15 +09:00 committed by GitHub
parent de6b5ed14d
commit 8007d5c814
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spacy/cli/pretrain.py
View File

@ -95,6 +95,13 @@ def verify_cli_args(config_path, output_dir, resume_path, epoch_resume):
"then the new directory will be created for you.", "then the new directory will be created for you.",
) )
if resume_path is not None: if resume_path is not None:
if resume_path.is_dir():
# This is necessary because Windows gives a Permission Denied when we
# try to open the directory later, which is confusing. See #7878
msg.fail(
"--resume-path should be a weights file, but {resume_path} is a directory.",
exits=True,
)
model_name = re.search(r"model\d+\.bin", str(resume_path)) model_name = re.search(r"model\d+\.bin", str(resume_path))
if not model_name and not epoch_resume: if not model_name and not epoch_resume:
msg.fail( msg.fail(