From 865caedebd040fc1f60e296c45693664e8de7a5b Mon Sep 17 00:00:00 2001 From: Paul O'Leary McCann Date: Sat, 3 Jul 2021 18:40:38 +0900 Subject: [PATCH] Remove XXX comment Comment wondered if there should be some subtraction to avoid double counting, but it probably doesn't matter because the diagonal is 0. --- spacy/ml/models/coref.py | 1 - 1 file changed, 1 deletion(-) diff --git a/spacy/ml/models/coref.py b/spacy/ml/models/coref.py index e77797d4a..9a3081bd8 100644 --- a/spacy/ml/models/coref.py +++ b/spacy/ml/models/coref.py @@ -455,7 +455,6 @@ def pairwise_sum(ops, mention_scores: Floats1d) -> Tuple[Floats2d, Callable]: out = ops.alloc1f(dim) for ii in range(dim): out[ii] = d_pwsum[:, ii].sum() + d_pwsum[ii, :].sum() - # XXX maybe subtract d_pwsum[ii,ii] to avoid double counting? return out