catch warnings instead of ignoring

This commit is contained in:
thomashacker 2022-11-11 16:39:24 +01:00
parent 0ace0fba49
commit 8b4415f29b

View File

@ -543,7 +543,6 @@ def test_spacy_blank():
assert nlp.config["training"]["dropout"] == 0.2 assert nlp.config["training"]["dropout"] == 0.2
assert nlp.meta["name"] == "my_custom_model" assert nlp.meta["name"] == "my_custom_model"
@pytest.mark.filterwarnings("ignore:\\[W124")
@pytest.mark.parametrize( @pytest.mark.parametrize(
"lang,target", "lang,target",
[ [
@ -567,9 +566,12 @@ def test_language_matching(lang, target):
Test that we can look up languages by equivalent or nearly-equivalent Test that we can look up languages by equivalent or nearly-equivalent
language codes. language codes.
""" """
assert find_matching_language(lang) == target if target is None:
assert find_matching_language(lang) == target
else:
with pytest.warns(UserWarning):
assert find_matching_language(lang) == target
@pytest.mark.filterwarnings("ignore:\\[W124")
@pytest.mark.parametrize( @pytest.mark.parametrize(
"lang,target", "lang,target",
[ [
@ -580,7 +582,6 @@ def test_language_matching(lang, target):
("mo", "ro"), ("mo", "ro"),
("is", "isl"), ("is", "isl"),
("xx", "mul"), ("xx", "mul"),
("mul", "mul"),
("no", "nb"), ("no", "nb"),
("pt-BR", "pt"), ("pt-BR", "pt"),
("zh-Hans", "zh"), ("zh-Hans", "zh"),
@ -591,8 +592,13 @@ def test_blank_languages(lang, target):
Test that we can get spacy.blank in various languages, including codes Test that we can get spacy.blank in various languages, including codes
that are defined to be equivalent or that match by CLDR language matching. that are defined to be equivalent or that match by CLDR language matching.
""" """
nlp = spacy.blank(lang) if lang == "en":
assert nlp.lang == target nlp = spacy.blank(lang)
assert nlp.lang == target
else:
with pytest.warns(UserWarning):
nlp = spacy.blank(lang)
assert nlp.lang == target
@pytest.mark.parametrize("value", [False, None, ["x", "y"], Language, Vocab]) @pytest.mark.parametrize("value", [False, None, ["x", "y"], Language, Vocab])