mirror of
https://github.com/explosion/spaCy.git
synced 2024-12-25 09:26:27 +03:00
Adjust [initialize.components] on Language.remove_pipe and Language.rename_pipe
This commit is contained in:
parent
9b3a934361
commit
8f018e47f8
|
@ -896,6 +896,10 @@ class Language:
|
|||
self._components[i] = (new_name, self._components[i][1])
|
||||
self._pipe_meta[new_name] = self._pipe_meta.pop(old_name)
|
||||
self._pipe_configs[new_name] = self._pipe_configs.pop(old_name)
|
||||
# Make sure [initialize] config is adjusted
|
||||
if old_name in self._config["initialize"]["components"]:
|
||||
init_cfg = self._config["initialize"]["components"].pop(old_name)
|
||||
self._config["initialize"]["components"][new_name] = init_cfg
|
||||
|
||||
def remove_pipe(self, name: str) -> Tuple[str, Callable[[Doc], Doc]]:
|
||||
"""Remove a component from the pipeline.
|
||||
|
@ -912,6 +916,9 @@ class Language:
|
|||
# because factory may be used for something else
|
||||
self._pipe_meta.pop(name)
|
||||
self._pipe_configs.pop(name)
|
||||
# Make sure name is removed from the [initialize] config
|
||||
if name in self._config["initialize"]["components"]:
|
||||
self._config["initialize"]["components"].pop(name)
|
||||
# Make sure the name is also removed from the set of disabled components
|
||||
if name in self.disabled:
|
||||
self._disabled.remove(name)
|
||||
|
|
|
@ -382,3 +382,25 @@ def test_warning_pipe_begin_training():
|
|||
|
||||
def begin_training(*args, **kwargs):
|
||||
...
|
||||
|
||||
|
||||
def test_pipe_methods_initialize():
|
||||
"""Test that the [initialize] config reflects the components correctly."""
|
||||
nlp = Language()
|
||||
nlp.add_pipe("tagger")
|
||||
assert "tagger" not in nlp.config["initialize"]["components"]
|
||||
nlp.config["initialize"]["components"]["tagger"] = {"labels": ["hello"]}
|
||||
assert nlp.config["initialize"]["components"]["tagger"] == {"labels": ["hello"]}
|
||||
nlp.remove_pipe("tagger")
|
||||
assert "tagger" not in nlp.config["initialize"]["components"]
|
||||
nlp.add_pipe("tagger")
|
||||
assert "tagger" not in nlp.config["initialize"]["components"]
|
||||
nlp.config["initialize"]["components"]["tagger"] = {"labels": ["hello"]}
|
||||
nlp.rename_pipe("tagger", "my_tagger")
|
||||
assert "tagger" not in nlp.config["initialize"]["components"]
|
||||
assert nlp.config["initialize"]["components"]["my_tagger"] == {"labels": ["hello"]}
|
||||
nlp.config["initialize"]["components"]["test"] = {"foo": "bar"}
|
||||
nlp.add_pipe("ner", name="test")
|
||||
assert "test" in nlp.config["initialize"]["components"]
|
||||
nlp.remove_pipe("test")
|
||||
assert "test" not in nlp.config["initialize"]["components"]
|
||||
|
|
Loading…
Reference in New Issue
Block a user