From a54f0cfc2b2d7283e423696ccb33c8242df06594 Mon Sep 17 00:00:00 2001 From: "Knut O. Hellan" Date: Mon, 8 Jul 2019 10:28:47 +0200 Subject: [PATCH] Norwegian tweaks (#3894) * Norwegian fix Add support for alternative past tense verb form (vaska). * Norwegian months Add all Norwegian months to tokenizer excpetions. * More Norwegian abbreviations Add more Norwegian abbreviations to tokenizer_exceptions. * Contributor agreement khellan Add signed contributor agreement for khellan (Knut O. Hellan). --- .github/contributors/khellan.md | 106 +++++++++++++++++++++++ spacy/lang/nb/lemmatizer/_lemma_rules.py | 1 + spacy/lang/nb/tokenizer_exceptions.py | 14 +++ 3 files changed, 121 insertions(+) create mode 100644 .github/contributors/khellan.md diff --git a/.github/contributors/khellan.md b/.github/contributors/khellan.md new file mode 100644 index 000000000..3e7f78ea4 --- /dev/null +++ b/.github/contributors/khellan.md @@ -0,0 +1,106 @@ +# spaCy contributor agreement + +This spaCy Contributor Agreement (**"SCA"**) is based on the +[Oracle Contributor Agreement](http://www.oracle.com/technetwork/oca-405177.pdf). +The SCA applies to any contribution that you make to any product or project +managed by us (the **"project"**), and sets out the intellectual property rights +you grant to us in the contributed materials. The term **"us"** shall mean +[ExplosionAI GmbH](https://explosion.ai/legal). The term +**"you"** shall mean the person or entity identified below. + +If you agree to be bound by these terms, fill in the information requested +below and include the filled-in version with your first pull request, under the +folder [`.github/contributors/`](/.github/contributors/). The name of the file +should be your GitHub username, with the extension `.md`. For example, the user +example_user would create the file `.github/contributors/example_user.md`. + +Read this agreement carefully before signing. These terms and conditions +constitute a binding legal agreement. + +## Contributor Agreement + +1. The term "contribution" or "contributed materials" means any source code, +object code, patch, tool, sample, graphic, specification, manual, +documentation, or any other material posted or submitted by you to the project. + +2. With respect to any worldwide copyrights, or copyright applications and +registrations, in your contribution: + + * you hereby assign to us joint ownership, and to the extent that such + assignment is or becomes invalid, ineffective or unenforceable, you hereby + grant to us a perpetual, irrevocable, non-exclusive, worldwide, no-charge, + royalty-free, unrestricted license to exercise all rights under those + copyrights. This includes, at our option, the right to sublicense these same + rights to third parties through multiple levels of sublicensees or other + licensing arrangements; + + * you agree that each of us can do all things in relation to your + contribution as if each of us were the sole owners, and if one of us makes + a derivative work of your contribution, the one who makes the derivative + work (or has it made will be the sole owner of that derivative work; + + * you agree that you will not assert any moral rights in your contribution + against us, our licensees or transferees; + + * you agree that we may register a copyright in your contribution and + exercise all ownership rights associated with it; and + + * you agree that neither of us has any duty to consult with, obtain the + consent of, pay or render an accounting to the other for any use or + distribution of your contribution. + +3. With respect to any patents you own, or that you can license without payment +to any third party, you hereby grant to us a perpetual, irrevocable, +non-exclusive, worldwide, no-charge, royalty-free license to: + + * make, have made, use, sell, offer to sell, import, and otherwise transfer + your contribution in whole or in part, alone or in combination with or + included in any product, work or materials arising out of the project to + which your contribution was submitted, and + + * at our option, to sublicense these same rights to third parties through + multiple levels of sublicensees or other licensing arrangements. + +4. Except as set out above, you keep all right, title, and interest in your +contribution. The rights that you grant to us under these terms are effective +on the date you first submitted a contribution to us, even if your submission +took place before the date you sign these terms. + +5. You covenant, represent, warrant and agree that: + + * Each contribution that you submit is and shall be an original work of + authorship and you can legally grant the rights set out in this SCA; + + * to the best of your knowledge, each contribution will not violate any + third party's copyrights, trademarks, patents, or other intellectual + property rights; and + + * each contribution shall be in compliance with U.S. export control laws and + other applicable export and import laws. You agree to notify us if you + become aware of any circumstance which would make any of the foregoing + representations inaccurate in any respect. We may publicly disclose your + participation in the project, including the fact that you have signed the SCA. + +6. This SCA is governed by the laws of the State of California and applicable +U.S. Federal law. Any choice of law rules will not apply. + +7. Please place an “x” on one of the applicable statement below. Please do NOT +mark both statements: + + * [x] I am signing on behalf of myself as an individual and no other person + or entity, including my employer, has or will have rights with respect to my + contributions. + + * [ ] I am signing on behalf of my employer or a legal entity and I have the + actual authority to contractually bind that entity. + +## Contributor Details + +| Field | Entry | +|------------------------------- | -------------------- | +| Name | Knut O. Hellan | +| Company name (if applicable) | | +| Title or role (if applicable) | | +| Date | 02.07.2019 | +| GitHub username | khellan | +| Website (optional) | knuthellan.com | diff --git a/spacy/lang/nb/lemmatizer/_lemma_rules.py b/spacy/lang/nb/lemmatizer/_lemma_rules.py index 32dde4735..9debc33e7 100644 --- a/spacy/lang/nb/lemmatizer/_lemma_rules.py +++ b/spacy/lang/nb/lemmatizer/_lemma_rules.py @@ -22,6 +22,7 @@ NOUN_RULES = [ VERB_RULES = [ ["er", "e"], # vasker -> vaske ["et", "e"], # vasket -> vaske + ["a", "e"], # vaska -> vaske ["es", "e"], # vaskes -> vaske ["te", "e"], # stekte -> steke ["år", "å"], # får -> få diff --git a/spacy/lang/nb/tokenizer_exceptions.py b/spacy/lang/nb/tokenizer_exceptions.py index 82cb70649..b57b53ed5 100644 --- a/spacy/lang/nb/tokenizer_exceptions.py +++ b/spacy/lang/nb/tokenizer_exceptions.py @@ -10,7 +10,15 @@ _exc = {} for exc_data in [ {ORTH: "jan.", LEMMA: "januar"}, {ORTH: "feb.", LEMMA: "februar"}, + {ORTH: "mar.", LEMMA: "mars"}, + {ORTH: "apr.", LEMMA: "april"}, + {ORTH: "jun.", LEMMA: "juni"}, {ORTH: "jul.", LEMMA: "juli"}, + {ORTH: "aug.", LEMMA: "august"}, + {ORTH: "sep.", LEMMA: "september"}, + {ORTH: "okt.", LEMMA: "oktober"}, + {ORTH: "nov.", LEMMA: "november"}, + {ORTH: "des.", LEMMA: "desember"}, ]: _exc[exc_data[ORTH]] = [exc_data] @@ -18,11 +26,13 @@ for exc_data in [ for orth in [ "adm.dir.", "a.m.", + "andelsnr", "Aq.", "b.c.", "bl.a.", "bla.", "bm.", + "bnr.", "bto.", "ca.", "cand.mag.", @@ -41,6 +51,7 @@ for orth in [ "el.", "e.l.", "et.", + "etc.", "etg.", "ev.", "evt.", @@ -76,6 +87,7 @@ for orth in [ "kgl.res.", "kl.", "komm.", + "kr.", "kst.", "lø.", "ma.", @@ -106,6 +118,7 @@ for orth in [ "o.l.", "on.", "op.", + "org." "osv.", "ovf.", "p.", @@ -130,6 +143,7 @@ for orth in [ "sep.", "siviling.", "sms.", + "snr.", "spm.", "sr.", "sst.",