Remove W106: HEAD and SENT_START in doc.from_array (#6086)

* Remove W106: HEAD and SENT_START in doc.from_array

This warning was hacky and being triggered too often.

* Fix test

spacy/errors.py

@@ -119,9 +119,6 @@ class Warnings:
     W105 = ("As of spaCy v3.0, the {matcher}.pipe method is deprecated. If you "
             "need to match on a stream of documents, you can use nlp.pipe and "
             "call the {matcher} on each Doc object.")
-    W106 = ("Both HEAD and SENT_START are included as attributes in "
-            "doc.from_array(). The parse trees based on the HEAD attribute "
-            "will override the values in SENT_START.")
     W107 = ("The property Doc.{prop} is deprecated. Use "
             "Doc.has_annotation(\"{attr}\") instead.")
 

spacy/tests/doc/test_doc_api.py

@@ -274,12 +274,11 @@ def test_doc_from_array_sent_starts(en_vocab):
     # fmt: on
     doc = get_doc(en_vocab, words=words, heads=heads, deps=deps)
 
-    # HEAD overrides SENT_START with warning
+    # HEAD overrides SENT_START without warning
     attrs = [SENT_START, HEAD]
     arr = doc.to_array(attrs)
     new_doc = Doc(en_vocab, words=words)
-    with pytest.warns(UserWarning):
-        new_doc.from_array(attrs, arr)
+    new_doc.from_array(attrs, arr)
 
     # no warning using default attrs
     attrs = doc._get_array_attrs()

spacy/tokens/doc.pyx

@@ -817,8 +817,6 @@ cdef class Doc:
         if array.dtype != numpy.uint64:
             warnings.warn(Warnings.W028.format(type=array.dtype))
 
-        if set(attrs) != set(Doc._get_array_attrs()) and SENT_START in attrs and HEAD in attrs:
-            warnings.warn(Warnings.W106)
         cdef int i, col
         cdef int32_t abs_head_index
         cdef attr_id_t attr_id