explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2024-12-24 17:06:29 +03:00
Code Issues Packages Projects Releases Wiki Activity

Skip test that fails on conda-forge on Windows

Browse Source 
Our multi-processing test fails on conda-forge on windows, I think
due to the way conda-forge executes the tests. It says too many
processes open or something.

We can add a patch to only skip the test on conda-forge, which is what
I'm doing for the v2.2.2 release. It's better to keep the conda-forge
and pip versions identical though, as the patches are harder to
maintain.
This commit is contained in:
Matthew Honnibal 2019-11-01 13:32:01 +01:00
parent 56ad3a3988
commit b1be2e99e9
1 changed files with 32 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
spacy/tests/test_language.py
View File

@ -4,7 +4,7 @@ from __future__ import unicode_literals
import itertools
import pytest
from spacy.compat import is_python2
from spacy.compat import is_python2, is_windows
from spacy.gold import GoldParse
from spacy.language import Language
from spacy.tokens import Doc, Span
@ -110,8 +110,20 @@ def texts():
return data
@pytest.mark.parametrize("n_process", [1, 2])
def test_language_pipe(nlp2, n_process, texts):
def test_language_pipe(nlp2, texts):
texts = texts * 10
expecteds = [nlp2(text) for text in texts]
docs = nlp2.pipe(texts, n_process=1, batch_size=2)
for doc, expected_doc in zip(docs, expecteds):
assert_docs_equal(doc, expected_doc)
@pytest.mark.skipif(
is_python2 or is_windows,
reason="python2 can't handle iterator properly? Fails windows conda-forge"
)
@pytest.mark.parametrize("n_process", [2, 3])
def test_language_pipe_multiprocess(nlp2, n_process, texts):
texts = texts * 10
expecteds = [nlp2(text) for text in texts]
docs = nlp2.pipe(texts, n_process=n_process, batch_size=2)
@ -123,7 +135,7 @@ def test_language_pipe(nlp2, n_process, texts):
@pytest.mark.skipif(
is_python2, reason="python2 seems to be unable to handle iterator properly"
)
@pytest.mark.parametrize("n_process", [1, 2])
@pytest.mark.parametrize("n_process", [1])
def test_language_pipe_stream(nlp2, n_process, texts):
# check if nlp.pipe can handle infinite length iterator properly.
stream_texts = itertools.cycle(texts)
@ -134,3 +146,19 @@ def test_language_pipe_stream(nlp2, n_process, texts):
n_fetch = 20
for doc, expected_doc in itertools.islice(zip(docs, expecteds), n_fetch):
assert_docs_equal(doc, expected_doc)
@pytest.mark.skipif(
is_python2 or is_windows,
reason="python2 can't handle iterator properly? Fails windows conda-forge"
)
@pytest.mark.parametrize("n_process", [2, 3])
def test_language_pipe_stream_multiprocess(nlp2, n_process, texts):
# check if nlp.pipe can handle infinite length iterator properly.
stream_texts = itertools.cycle(texts)
texts0, texts1 = itertools.tee(stream_texts)
expecteds = (nlp2(text) for text in texts0)
docs = nlp2.pipe(texts1, n_process=n_process, batch_size=2)
n_fetch = 20
for doc, expected_doc in itertools.islice(zip(docs, expecteds), n_fetch):
assert_docs_equal(doc, expected_doc)