explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2024-12-25 17:36:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix in nlp.replace_pipe (#5875)

Browse Source 
* bugfix and unit test

* merge two conditions
This commit is contained in:
Sofie Van Landeghem 2020-08-05 09:30:58 +02:00 committed by GitHub
parent b795f02fbd
commit b88c5c701a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
spacy/language.py
View File

@ -805,7 +805,8 @@ class Language:
# to Language.pipeline to make sure the configs are handled correctly # to Language.pipeline to make sure the configs are handled correctly
pipe_index = self.pipe_names.index(name) pipe_index = self.pipe_names.index(name)
self.remove_pipe(name) self.remove_pipe(name)
if not len(self.pipeline): # we have no components to insert before/after if not len(self.pipeline) or pipe_index == len(self.pipeline):
# we have no components to insert before/after, or we're replacing the last component
self.add_pipe(factory_name, name=name) self.add_pipe(factory_name, name=name)
else: else:
self.add_pipe(factory_name, name=name, before=pipe_index) self.add_pipe(factory_name, name=name, before=pipe_index)

8
spacy/tests/pipeline/test_pipe_methods.py
View File

@ -70,6 +70,14 @@ def test_replace_pipe(nlp, name, replacement, invalid_replacement):
assert nlp.get_pipe(name) == nlp.create_pipe(replacement) assert nlp.get_pipe(name) == nlp.create_pipe(replacement)
def test_replace_last_pipe(nlp):
nlp.add_pipe("sentencizer")
nlp.add_pipe("ner")
assert nlp.pipe_names == ["sentencizer", "ner"]
nlp.replace_pipe("ner", "ner")
assert nlp.pipe_names == ["sentencizer", "ner"]
@pytest.mark.parametrize("old_name,new_name", [("old_pipe", "new_pipe")]) @pytest.mark.parametrize("old_name,new_name", [("old_pipe", "new_pipe")])
def test_rename_pipe(nlp, old_name, new_name): def test_rename_pipe(nlp, old_name, new_name):
with pytest.raises(ValueError): with pytest.raises(ValueError):