explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2025-01-11 17:56:30 +03:00
Code Issues Packages Projects Releases Wiki Activity

* Fix Issue #375: noun phrase iteration results in index error if noun phrases are merged during the loop. Fix by accumulating the spans inside the noun_chunks property, allowing the Span index tricks to work.

Browse Source
This commit is contained in:
Matthew Honnibal 2016-05-20 10:14:06 +02:00
parent 13fad36e49
commit cdc10e9a1c
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
spacy/tokens/doc.pyx
View File

@ -247,8 +247,15 @@ cdef class Doc:
"requires data to be installed. If you haven't done so, run: " "requires data to be installed. If you haven't done so, run: "
"\npython -m spacy.%s.download all\n" "\npython -m spacy.%s.download all\n"
"to install the data" % self.vocab.lang) "to install the data" % self.vocab.lang)
# Accumulate the result before beginning to iterate over it. This prevents
# the tokenisation from being changed out from under us during the iteration.
# The tricky thing here is that Span accepts its tokenisation changing,
# so it's okay once we have the Span objects. See Issue #375
spans = []
for start, end, label in self.noun_chunks_iterator(self): for start, end, label in self.noun_chunks_iterator(self):
yield Span(self, start, end, label=label) spans.append(Span(self, start, end, label=label))
for span in spans:
yield span
@property @property
def sents(self): def sents(self):