From d89a1a91ac9dfe8f9a4941ece7a76aab8453c591 Mon Sep 17 00:00:00 2001 From: Matthew Honnibal Date: Tue, 25 Sep 2018 21:07:48 +0200 Subject: [PATCH] Update morphology tests --- spacy/tests/morphology/test_morph_features.py | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/spacy/tests/morphology/test_morph_features.py b/spacy/tests/morphology/test_morph_features.py index f0610b745..391fd1337 100644 --- a/spacy/tests/morphology/test_morph_features.py +++ b/spacy/tests/morphology/test_morph_features.py @@ -13,13 +13,29 @@ def morphology(): def test_init(morphology): pass -def test_add_tag_with_string_names(morphology): - morphology.add({"Case_gen", "Number_Sing"}) +def test_add_morphology_with_string_names(morphology): + morphology.add({"Case_gen", "Number_sing"}) -def test_add_tag_with_int_ids(morphology): +def test_add_morphology_with_int_ids(morphology): morphology.add({Case_gen, Number_sing}) -def test_add_tag_with_mix_strings_and_ints(morphology): +def test_add_morphology_with_mix_strings_and_ints(morphology): morphology.add({PunctSide_ini, 'VerbType_aux'}) +def test_morphology_tags_hash_distinctly(morphology): + tag1 = morphology.add({PunctSide_ini, 'VerbType_aux'}) + tag2 = morphology.add({"Case_gen", 'Number_sing'}) + assert tag1 != tag2 + +def test_morphology_tags_hash_independent_of_order(morphology): + tag1 = morphology.add({"Case_gen", 'Number_sing'}) + tag2 = morphology.add({"Number_sing", "Case_gen"}) + assert tag1 == tag2 + +def test_update_morphology_tag(morphology): + tag1 = morphology.add({"Case_gen"}) + tag2 = morphology.update(tag1, {"Number_sing"}) + assert tag1 != tag2 + tag3 = morphology.add({"Number_sing", "Case_gen"}) + assert tag2 == tag3