From 936de72ffca9963b2cdc06750fd3d7fd5cf76e54 Mon Sep 17 00:00:00 2001 From: Ines Montani Date: Sat, 18 Feb 2017 12:42:11 +0100 Subject: [PATCH 1/6] Update CONTRIBUTING.md --- CONTRIBUTING.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 5825efa73..7ab852add 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -39,6 +39,7 @@ We use the following system to tag our issues: | [`linux`](https://github.com/explosion/spaCy/labels/linux), [`osx`](https://github.com/explosion/spaCy/labels/osx), [`windows`](https://github.com/explosion/spaCy/labels/windows) | Issues related to the specific operating systems | | [`pip`](https://github.com/explosion/spaCy/labels/pip), [`conda`](https://github.com/explosion/spaCy/labels/conda) | Issues related to the specific package managers | | [`duplicate`](https://github.com/explosion/spaCy/labels/duplicate) | Duplicates, i.e. issues that have been reported before | +| [`meta`](https://github.com/explosion/spaCy/labels/duplicate) | Meta topics, e.g. repo organisation and issue management | | [`help wanted`](https://github.com/explosion/spaCy/labels/help%20wanted) | Requests for contributions | | [`help wanted (easy)`](https://github.com/explosion/spaCy/labels/help%20wanted%20%28easy%29) | Requests for contributions suitable for begginners | From a3a3796ecd5c7ac45057cafbfc7610ac37cded77 Mon Sep 17 00:00:00 2001 From: Ines Montani Date: Sat, 18 Feb 2017 12:42:35 +0100 Subject: [PATCH 2/6] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7ab852add..39f3efe06 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -39,7 +39,7 @@ We use the following system to tag our issues: | [`linux`](https://github.com/explosion/spaCy/labels/linux), [`osx`](https://github.com/explosion/spaCy/labels/osx), [`windows`](https://github.com/explosion/spaCy/labels/windows) | Issues related to the specific operating systems | | [`pip`](https://github.com/explosion/spaCy/labels/pip), [`conda`](https://github.com/explosion/spaCy/labels/conda) | Issues related to the specific package managers | | [`duplicate`](https://github.com/explosion/spaCy/labels/duplicate) | Duplicates, i.e. issues that have been reported before | -| [`meta`](https://github.com/explosion/spaCy/labels/duplicate) | Meta topics, e.g. repo organisation and issue management | +| [`meta`](https://github.com/explosion/spaCy/labels/meta) | Meta topics, e.g. repo organisation and issue management | | [`help wanted`](https://github.com/explosion/spaCy/labels/help%20wanted) | Requests for contributions | | [`help wanted (easy)`](https://github.com/explosion/spaCy/labels/help%20wanted%20%28easy%29) | Requests for contributions suitable for begginners | From 9c04d97e22c301c6fc5403040a1ad5b5e62153bb Mon Sep 17 00:00:00 2001 From: Ines Montani Date: Sat, 18 Feb 2017 12:47:41 +0100 Subject: [PATCH 3/6] Update CONTRIBUTING.md --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 39f3efe06..bb0a3ccae 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -25,7 +25,7 @@ If you've discovered a bug, you can also submit a [regression test](#fixing-bugs ### Issue labels -We use the following system to tag our issues: +To distinguish issues that are opened by us, the maintainers, we usually add a 💫 to the title. We also use the following system to tag our issues: | Issue label | Description | | --- | --- | From 30ce2a67935199c94d8ae17acbd0b1dd6f08e665 Mon Sep 17 00:00:00 2001 From: ines Date: Sat, 18 Feb 2017 14:10:18 +0100 Subject: [PATCH 4/6] Exclude "shed" and "Shed" from tokenizer exceptions (see #847) --- spacy/en/tokenizer_exceptions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spacy/en/tokenizer_exceptions.py b/spacy/en/tokenizer_exceptions.py index c562b38ee..fac5465ac 100644 --- a/spacy/en/tokenizer_exceptions.py +++ b/spacy/en/tokenizer_exceptions.py @@ -7,7 +7,7 @@ from ..language_data import PRON_LEMMA EXC = {} -EXCLUDE_EXC = ["Ill", "ill", "Its", "its", "Hell", "hell", "Shell", "shell", "were", "Were", "Well", "well", "Whore", "whore"] +EXCLUDE_EXC = ["Ill", "ill", "Its", "its", "Hell", "hell", "Shell", "shell", "Shed", "shed", "were", "Were", "Well", "well", "Whore", "whore"] # Pronouns From 67991b6e5f95b2a546f6023c0cc0d831e8556620 Mon Sep 17 00:00:00 2001 From: ines Date: Sat, 18 Feb 2017 14:10:41 +0100 Subject: [PATCH 5/6] Add more test cases to #775 regression test to cover #847 --- spacy/tests/regression/test_issue775.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spacy/tests/regression/test_issue775.py b/spacy/tests/regression/test_issue775.py index fe1c89240..2b5cd2df5 100644 --- a/spacy/tests/regression/test_issue775.py +++ b/spacy/tests/regression/test_issue775.py @@ -4,7 +4,7 @@ from __future__ import unicode_literals import pytest -@pytest.mark.parametrize('text', ["Shell", "shell"]) +@pytest.mark.parametrize('text', ["Shell", "shell", "Shed", "shed"]) def test_issue775(en_tokenizer, text): """Test that 'Shell' and 'shell' are excluded from the contractions generated by the English tokenizer exceptions.""" From 29adbef095c04e21a691e912671e4ec21082b047 Mon Sep 17 00:00:00 2001 From: Ines Montani Date: Sat, 18 Feb 2017 14:34:03 +0100 Subject: [PATCH 6/6] Update CONTRIBUTING.md --- CONTRIBUTING.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index bb0a3ccae..6b3443f61 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -45,14 +45,12 @@ To distinguish issues that are opened by us, the maintainers, we usually add a ## Contributing to the code base -Coming soon. - +You don't have to be an NLP expert or Python pro to contribute, and we're happy to help you get started. If you're new to spaCy, a good place to start is the [`help wanted (easy)`](https://github.com/explosion/spaCy/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted+%28easy%29%22) label, which we use to tag bugs and feature requests that are easy and self-contained. If you've decided to take on one of these problems and you're making good progress, don't forget to add a quick comment to the issue. You can also use the issue to ask questions, or share your work in progress. ### Conventions for Python Coming soon. - ### Conventions for Cython Coming soon.