explosion/spaCy
1
1
Fork 0
mirror of https://github.com/explosion/spaCy.git synced 2024-09-21 03:19:13 +03:00
Code Issues Packages Projects Releases Wiki Activity

Test if closing explicitly solves recursive lock issues (#13304)

Browse Source
This commit is contained in:
Daniël de Kok 2024-02-05 10:07:03 +01:00 committed by GitHub
parent 40422ff904
commit e1249d3722
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spacy/language.py
View File

@ -1716,6 +1716,7 @@ class Language:
# is done, so that they can exit gracefully. # is done, so that they can exit gracefully.
for q in texts_q: for q in texts_q:
q.put(_WORK_DONE_SENTINEL) q.put(_WORK_DONE_SENTINEL)
q.close()
# Otherwise, we are stopping because the error handler raised an # Otherwise, we are stopping because the error handler raised an
# exception. The sentinel will be last to go out of the queue. # exception. The sentinel will be last to go out of the queue.
@ -2347,7 +2348,8 @@ def _apply_pipes(
# Stop working if we encounter the end-of-work sentinel. # Stop working if we encounter the end-of-work sentinel.
if isinstance(texts_with_ctx, _WorkDoneSentinel): if isinstance(texts_with_ctx, _WorkDoneSentinel):
return sender.close()
receiver.close()
docs = ( docs = (
ensure_doc(doc_like, context) for doc_like, context in texts_with_ctx ensure_doc(doc_like, context) for doc_like, context in texts_with_ctx
@ -2371,7 +2373,8 @@ def _apply_pipes(
# Parent has closed the pipe prematurely. This happens when a # Parent has closed the pipe prematurely. This happens when a
# worker encounters an error and the error handler is set to # worker encounters an error and the error handler is set to
# stop processing. # stop processing.
return sender.close()
receiver.close()
class _Sender: class _Sender: