From e61f0a40356bfbecac16c23f67104617920fa2c4 Mon Sep 17 00:00:00 2001 From: Lj Miranda Date: Tue, 17 Jan 2023 10:17:29 +0800 Subject: [PATCH] Update how spancat_exclusive is constructed In this commit, I added the following: - Put the default values of negative_weight and allow_overlap in the default_config dictionary. - Rename make_spancat -> make_exclusive_spancat --- spacy/pipeline/spancat_exclusive.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/spacy/pipeline/spancat_exclusive.py b/spacy/pipeline/spancat_exclusive.py index 1acf9965d..d1c3fd18a 100644 --- a/spacy/pipeline/spancat_exclusive.py +++ b/spacy/pipeline/spancat_exclusive.py @@ -46,22 +46,24 @@ DEFAULT_EXCL_SPANCAT_MODEL = Config().from_str(spancat_excl_default_config)["mod "spancat_exclusive", assigns=["doc.spans"], default_config={ - "spans_key": "sc", - "model": DEFAULT_EXCL_SPANCAT_MODEL, "suggester": {"@misc": "spacy.ngram_suggester.v1", "sizes": [1, 2, 3]}, + "model": DEFAULT_EXCL_SPANCAT_MODEL, + "spans_key": "sc", "scorer": {"@scorers": "spacy.spancat_scorer.v1"}, + "negative_weight": 1.0, + "allow_overlap": True, }, default_score_weights={"spans_sc_f": 1.0, "spans_sc_p": 0.0, "spans_sc_r": 0.0}, ) -def make_spancat( +def make_exclusive_spancat( nlp: Language, name: str, suggester: Suggester, model: Model[Tuple[List[Doc], Ragged], Floats2d], spans_key: str, scorer: Optional[Callable], - negative_weight: float = 1.0, - allow_overlap: bool = True, + negative_weight: float, + allow_overlap: bool, ) -> "Exclusive_SpanCategorizer": """Create an Exclusive_SpanCategorizer component. The span categorizer consists of two parts: a suggester function that proposes candidate spans, and a labeler