From ef709de8ca22bd4fc572ecaa1a938cbeef2f4bf3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Danie=CC=88l=20de=20Kok?= <me@danieldk.eu>
Date: Fri, 3 Feb 2023 14:23:04 +0100
Subject: [PATCH] Add comment why we moved `finish_update` to a separate loop

---
 spacy/language.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/spacy/language.py b/spacy/language.py
index 2364e0893..0763c09cf 100644
--- a/spacy/language.py
+++ b/spacy/language.py
@@ -1168,6 +1168,9 @@ class Language:
                     examples,
                 ):
                     eg.predicted = doc
+        # Only finish the update after all component updates are done. Some
+        # components may share weights (such as tok2vec) and we only want
+        # to apply weight updates after all gradients are accumulated.
         for name, proc in self.pipeline:
             if (
                 name not in exclude