From f53dc46f6552f1b85fbff47bbc82e5e8251a4b9f Mon Sep 17 00:00:00 2001 From: Raphael Mitsch Date: Thu, 2 Mar 2023 13:24:53 +0100 Subject: [PATCH] Drop generate_from_disk(). --- spacy/kb/kb.pyx | 14 -------------- spacy/kb/kb_in_memory.pyx | 8 -------- 2 files changed, 22 deletions(-) diff --git a/spacy/kb/kb.pyx b/spacy/kb/kb.pyx index 61c7e5fde..ab8960773 100644 --- a/spacy/kb/kb.pyx +++ b/spacy/kb/kb.pyx @@ -109,20 +109,6 @@ cdef class KnowledgeBase: Errors.E1045.format(parent="KnowledgeBase", method="from_disk", name=self.__name__) ) - @classmethod - def generate_from_disk( - cls: Type[_KBType], path: Union[str, Path], exclude: Iterable[str] = SimpleFrozenList() - ) -> _KBType: - """ - Factory method for generating KnowledgeBase subclass instance from file. - path (Union[str, Path]): Target file path. - exclude (Iterable[str]): List of components to exclude. - return (_KBType): Instance of KnowledgeBase subclass generated from file. - """ - raise NotImplementedError( - Errors.E1044.format(parent="KnowledgeBase", method="generate_from_disk", name=cls.__name__) - ) - def is_empty(self) -> bool: """Returns whether KnowledgeBase is empty. RETURNS (bool): Whether KnowledgeBase is empty. diff --git a/spacy/kb/kb_in_memory.pyx b/spacy/kb/kb_in_memory.pyx index 43e6b1dc7..586289335 100644 --- a/spacy/kb/kb_in_memory.pyx +++ b/spacy/kb/kb_in_memory.pyx @@ -49,14 +49,6 @@ cdef class InMemoryLookupKB(KnowledgeBase): def is_empty(self): return len(self) == 0 - @classmethod - def generate_from_disk( - cls, path: Union[str, Path], exclude: Iterable[str] = SimpleFrozenList() - ) -> "InMemoryLookupKB": - kb = InMemoryLookupKB(vocab=Vocab(strings=["."]), entity_vector_length=1) - kb.from_disk(path) - return kb - def __len__(self): return self.get_size_entities()