mirror of
https://github.com/explosion/spaCy.git
synced 2024-11-11 04:08:09 +03:00
8aa7882762
See #3028. The solution in this patch is pretty debateable. What we do is give the TokenC struct a .norm field, by repurposing the previously idle .sense attribute. It's nice to repurpose a previous field because it means the TokenC doesn't change size, so even if someone's using the internals very deeply, nothing will break. The weird thing here is that the TokenC and the LexemeC both have an attribute named NORM. This arguably assists in backwards compatibility. On the other hand, maybe it's really bad! We're changing the semantics of the attribute subtly, so maybe it's better if someone calling lex.norm gets a breakage, and instead is told to write lex.default_norm? Overall I believe this patch makes the NORM feature work the way we sort of expected it to work. Certainly it's much more like how the docs describe it, and more in line with how we've been directing people to use the norm attribute. We'll also be able to use token.norm to do stuff like spelling correction, which is pretty cool. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| _test_issue2800.py | ||
| test_issue1-1000.py | ||
| test_issue1001-1500.py | ||
| test_issue1501-2000.py | ||
| test_issue2001-2500.py | ||
| test_issue2564.py | ||
| test_issue2569.py | ||
| test_issue2626.py | ||
| test_issue2671.py | ||
| test_issue2754.py | ||
| test_issue2772.py | ||
| test_issue2782.py | ||