mirror of
https://github.com/explosion/spaCy.git
synced 2024-09-21 19:39:13 +03:00
75f3234404
## Description Related issues: #2379 (should be fixed by separating model tests) * **total execution time down from > 300 seconds to under 60 seconds** 🎉 * removed all model-specific tests that could only really be run manually anyway – those will now live in a separate test suite in the [`spacy-models`](https://github.com/explosion/spacy-models) repository and are already integrated into our new model training infrastructure * changed all relative imports to absolute imports to prepare for moving the test suite from `/spacy/tests` to `/tests` (it'll now always test against the installed version) * merged old regression tests into collections, e.g. `test_issue1001-1500.py` (about 90% of the regression tests are very short anyways) * tidied up and rewrote existing tests wherever possible ### Todo - [ ] move tests to `/tests` and adjust CI commands accordingly - [x] move model test suite from internal repo to `spacy-models` - [x] ~~investigate why `pipeline/test_textcat.py` is flakey~~ - [x] review old regression tests (leftover files) and see if they can be merged, simplified or deleted - [ ] update documentation on how to run tests ### Types of change enhancement, tests ## Checklist <!--- Before you submit the PR, go over this checklist and make sure you can tick off all the boxes. [] -> [x] --> - [x] I have submitted the spaCy Contributor Agreement. - [x] I ran the tests, and all new and existing tests passed. - [ ] My changes don't require a change to the documentation, or if they do, I've added all required information.
98 lines
3.2 KiB
Python
98 lines
3.2 KiB
Python
# coding: utf-8
|
|
from __future__ import unicode_literals
|
|
|
|
import pytest
|
|
from mock import Mock
|
|
from spacy.tokens import Doc, Span, Token
|
|
from spacy.tokens.underscore import Underscore
|
|
|
|
|
|
def test_create_doc_underscore():
|
|
doc = Mock()
|
|
doc.doc = doc
|
|
uscore = Underscore(Underscore.doc_extensions, doc)
|
|
assert uscore._doc is doc
|
|
assert uscore._start is None
|
|
assert uscore._end is None
|
|
|
|
|
|
def test_doc_underscore_getattr_setattr():
|
|
doc = Mock()
|
|
doc.doc = doc
|
|
doc.user_data = {}
|
|
Underscore.doc_extensions['hello'] = (False, None, None, None)
|
|
doc._ = Underscore(Underscore.doc_extensions, doc)
|
|
assert doc._.hello == False
|
|
doc._.hello = True
|
|
assert doc._.hello == True
|
|
|
|
|
|
def test_create_span_underscore():
|
|
span = Mock(doc=Mock(), start=0, end=2)
|
|
uscore = Underscore(Underscore.span_extensions, span,
|
|
start=span.start, end=span.end)
|
|
assert uscore._doc is span.doc
|
|
assert uscore._start is span.start
|
|
assert uscore._end is span.end
|
|
|
|
|
|
def test_span_underscore_getter_setter():
|
|
span = Mock(doc=Mock(), start=0, end=2)
|
|
Underscore.span_extensions['hello'] = (None, None,
|
|
lambda s: (s.start, 'hi'),
|
|
lambda s, value: setattr(s, 'start',
|
|
value))
|
|
span._ = Underscore(Underscore.span_extensions, span,
|
|
start=span.start, end=span.end)
|
|
|
|
assert span._.hello == (0, 'hi')
|
|
span._.hello = 1
|
|
assert span._.hello == (1, 'hi')
|
|
|
|
|
|
def test_token_underscore_method():
|
|
token = Mock(doc=Mock(), idx=7, say_cheese=lambda token: 'cheese')
|
|
Underscore.token_extensions['hello'] = (None, token.say_cheese,
|
|
None, None)
|
|
token._ = Underscore(Underscore.token_extensions, token, start=token.idx)
|
|
assert token._.hello() == 'cheese'
|
|
|
|
|
|
@pytest.mark.parametrize('obj', [Doc, Span, Token])
|
|
def test_doc_underscore_remove_extension(obj):
|
|
ext_name = 'to_be_removed'
|
|
obj.set_extension(ext_name, default=False)
|
|
assert obj.has_extension(ext_name)
|
|
obj.remove_extension(ext_name)
|
|
assert not obj.has_extension(ext_name)
|
|
|
|
|
|
@pytest.mark.parametrize('obj', [Doc, Span, Token])
|
|
def test_underscore_raises_for_dup(obj):
|
|
obj.set_extension('test', default=None)
|
|
with pytest.raises(ValueError):
|
|
obj.set_extension('test', default=None)
|
|
|
|
|
|
@pytest.mark.parametrize('invalid_kwargs', [
|
|
{'getter': None, 'setter': lambda: None},
|
|
{'default': None, 'method': lambda: None, 'getter': lambda: None},
|
|
{'setter': lambda: None},
|
|
{'default': None, 'method': lambda: None},
|
|
{'getter': True}])
|
|
def test_underscore_raises_for_invalid(invalid_kwargs):
|
|
invalid_kwargs['force'] = True
|
|
with pytest.raises(ValueError):
|
|
Doc.set_extension('test', **invalid_kwargs)
|
|
|
|
|
|
@pytest.mark.parametrize('valid_kwargs', [
|
|
{'getter': lambda: None},
|
|
{'getter': lambda: None, 'setter': lambda: None},
|
|
{'default': 'hello'},
|
|
{'default': None},
|
|
{'method': lambda: None}])
|
|
def test_underscore_accepts_valid(valid_kwargs):
|
|
valid_kwargs['force'] = True
|
|
Doc.set_extension('test', **valid_kwargs)
|