mirror of
https://github.com/explosion/spaCy.git
synced 2024-09-21 19:39:13 +03:00
75f3234404
## Description Related issues: #2379 (should be fixed by separating model tests) * **total execution time down from > 300 seconds to under 60 seconds** 🎉 * removed all model-specific tests that could only really be run manually anyway – those will now live in a separate test suite in the [`spacy-models`](https://github.com/explosion/spacy-models) repository and are already integrated into our new model training infrastructure * changed all relative imports to absolute imports to prepare for moving the test suite from `/spacy/tests` to `/tests` (it'll now always test against the installed version) * merged old regression tests into collections, e.g. `test_issue1001-1500.py` (about 90% of the regression tests are very short anyways) * tidied up and rewrote existing tests wherever possible ### Todo - [ ] move tests to `/tests` and adjust CI commands accordingly - [x] move model test suite from internal repo to `spacy-models` - [x] ~~investigate why `pipeline/test_textcat.py` is flakey~~ - [x] review old regression tests (leftover files) and see if they can be merged, simplified or deleted - [ ] update documentation on how to run tests ### Types of change enhancement, tests ## Checklist <!--- Before you submit the PR, go over this checklist and make sure you can tick off all the boxes. [] -> [x] --> - [x] I have submitted the spaCy Contributor Agreement. - [x] I ran the tests, and all new and existing tests passed. - [ ] My changes don't require a change to the documentation, or if they do, I've added all required information.
115 lines
3.2 KiB
Python
115 lines
3.2 KiB
Python
# coding: utf8
|
|
from __future__ import unicode_literals
|
|
|
|
import pytest
|
|
from spacy.language import Language
|
|
|
|
|
|
@pytest.fixture
|
|
def nlp():
|
|
return Language()
|
|
|
|
|
|
def new_pipe(doc):
|
|
return doc
|
|
|
|
|
|
def test_add_pipe_no_name(nlp):
|
|
nlp.add_pipe(new_pipe)
|
|
assert 'new_pipe' in nlp.pipe_names
|
|
|
|
|
|
def test_add_pipe_duplicate_name(nlp):
|
|
nlp.add_pipe(new_pipe, name='duplicate_name')
|
|
with pytest.raises(ValueError):
|
|
nlp.add_pipe(new_pipe, name='duplicate_name')
|
|
|
|
|
|
@pytest.mark.parametrize('name', ['parser'])
|
|
def test_add_pipe_first(nlp, name):
|
|
nlp.add_pipe(new_pipe, name=name, first=True)
|
|
assert nlp.pipeline[0][0] == name
|
|
|
|
|
|
@pytest.mark.parametrize('name1,name2', [('parser', 'lambda_pipe')])
|
|
def test_add_pipe_last(nlp, name1, name2):
|
|
nlp.add_pipe(lambda doc: doc, name=name2)
|
|
nlp.add_pipe(new_pipe, name=name1, last=True)
|
|
assert nlp.pipeline[0][0] != name1
|
|
assert nlp.pipeline[-1][0] == name1
|
|
|
|
|
|
def test_cant_add_pipe_first_and_last(nlp):
|
|
with pytest.raises(ValueError):
|
|
nlp.add_pipe(new_pipe, first=True, last=True)
|
|
|
|
|
|
@pytest.mark.parametrize('name', ['my_component'])
|
|
def test_get_pipe(nlp, name):
|
|
with pytest.raises(KeyError):
|
|
nlp.get_pipe(name)
|
|
nlp.add_pipe(new_pipe, name=name)
|
|
assert nlp.get_pipe(name) == new_pipe
|
|
|
|
|
|
@pytest.mark.parametrize('name,replacement', [('my_component', lambda doc: doc)])
|
|
def test_replace_pipe(nlp, name, replacement):
|
|
with pytest.raises(ValueError):
|
|
nlp.replace_pipe(name, new_pipe)
|
|
nlp.add_pipe(new_pipe, name=name)
|
|
nlp.replace_pipe(name, replacement)
|
|
assert nlp.get_pipe(name) != new_pipe
|
|
assert nlp.get_pipe(name) == replacement
|
|
|
|
|
|
@pytest.mark.parametrize('old_name,new_name', [('old_pipe', 'new_pipe')])
|
|
def test_rename_pipe(nlp, old_name, new_name):
|
|
with pytest.raises(ValueError):
|
|
nlp.rename_pipe(old_name, new_name)
|
|
nlp.add_pipe(new_pipe, name=old_name)
|
|
nlp.rename_pipe(old_name, new_name)
|
|
assert nlp.pipeline[0][0] == new_name
|
|
|
|
|
|
@pytest.mark.parametrize('name', ['my_component'])
|
|
def test_remove_pipe(nlp, name):
|
|
with pytest.raises(ValueError):
|
|
nlp.remove_pipe(name)
|
|
nlp.add_pipe(new_pipe, name=name)
|
|
assert len(nlp.pipeline) == 1
|
|
removed_name, removed_component = nlp.remove_pipe(name)
|
|
assert not len(nlp.pipeline)
|
|
assert removed_name == name
|
|
assert removed_component == new_pipe
|
|
|
|
|
|
@pytest.mark.parametrize('name', ['my_component'])
|
|
def test_disable_pipes_method(nlp, name):
|
|
nlp.add_pipe(new_pipe, name=name)
|
|
assert nlp.has_pipe(name)
|
|
disabled = nlp.disable_pipes(name)
|
|
assert not nlp.has_pipe(name)
|
|
disabled.restore()
|
|
|
|
|
|
@pytest.mark.parametrize('name', ['my_component'])
|
|
def test_disable_pipes_context(nlp, name):
|
|
nlp.add_pipe(new_pipe, name=name)
|
|
assert nlp.has_pipe(name)
|
|
with nlp.disable_pipes(name):
|
|
assert not nlp.has_pipe(name)
|
|
assert nlp.has_pipe(name)
|
|
|
|
|
|
@pytest.mark.parametrize('n_pipes', [100])
|
|
def test_add_lots_of_pipes(nlp, n_pipes):
|
|
for i in range(n_pipes):
|
|
nlp.add_pipe(lambda doc: doc, name='pipe_%d' % i)
|
|
assert len(nlp.pipe_names) == n_pipes
|
|
|
|
|
|
@pytest.mark.parametrize('component', ['ner', {'hello': 'world'}])
|
|
def test_raise_for_invalid_components(nlp, component):
|
|
with pytest.raises(ValueError):
|
|
nlp.add_pipe(component)
|