graphql-python/graphene-django
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene-django.git synced 2025-07-13 09:42:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Start raising PendingDeprecationWarnings for using only_fields and exclude_fields

Browse Source
This commit is contained in:
Jonathan Kim 2019-07-09 13:47:35 +01:00
parent 730e17f23c
commit 022748cc0f
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
graphene_django/types.py
View File

@ -1,3 +1,4 @@
import warnings
from collections import OrderedDict from collections import OrderedDict
import six import six
@ -123,6 +124,11 @@ class DjangoObjectType(ObjectType):
if only_fields and fields: if only_fields and fields:
raise Exception("Can't set both only_fields and fields") raise Exception("Can't set both only_fields and fields")
if only_fields: if only_fields:
warnings.warn(
"Defining `only_fields` is deprecated in favour of `fields`.",
PendingDeprecationWarning,
stacklevel=2,
)
fields = only_fields fields = only_fields
if fields and fields != ALL_FIELDS and not isinstance(fields, (list, tuple)): if fields and fields != ALL_FIELDS and not isinstance(fields, (list, tuple)):
raise TypeError( raise TypeError(
@ -137,6 +143,11 @@ class DjangoObjectType(ObjectType):
if exclude_fields and exclude: if exclude_fields and exclude:
raise Exception("Can't set both exclude_fields and exclude") raise Exception("Can't set both exclude_fields and exclude")
if exclude_fields: if exclude_fields:
warnings.warn(
"Defining `exclude_fields` is deprecated in favour of `exclude`.",
PendingDeprecationWarning,
stacklevel=2,
)
exclude = exclude_fields exclude = exclude_fields
if exclude and not isinstance(exclude, (list, tuple)): if exclude and not isinstance(exclude, (list, tuple)):
raise TypeError( raise TypeError(