mirror of
https://github.com/graphql-python/graphene-django.git
synced 2025-07-10 16:22:20 +03:00
Pass args directly to improve clarity
This commit is contained in:
parent
f48d54b64c
commit
2e4c6a25dc
|
@ -303,7 +303,9 @@ class GraphQLView(View):
|
||||||
return None
|
return None
|
||||||
raise HttpError(HttpResponseBadRequest("Must provide query string."))
|
raise HttpError(HttpResponseBadRequest("Must provide query string."))
|
||||||
|
|
||||||
schema_validation_errors = validate_schema(self.schema.graphql_schema)
|
schema = self.schema.graphql_schema
|
||||||
|
|
||||||
|
schema_validation_errors = validate_schema(schema)
|
||||||
if schema_validation_errors:
|
if schema_validation_errors:
|
||||||
return ExecutionResult(data=None, errors=schema_validation_errors)
|
return ExecutionResult(data=None, errors=schema_validation_errors)
|
||||||
|
|
||||||
|
@ -349,8 +351,7 @@ class GraphQLView(View):
|
||||||
)
|
)
|
||||||
)
|
)
|
||||||
|
|
||||||
execute_args = (self.schema.graphql_schema, document)
|
validation_errors = validate(schema, document)
|
||||||
validation_errors = validate(*execute_args)
|
|
||||||
|
|
||||||
if validation_errors:
|
if validation_errors:
|
||||||
return ExecutionResult(data=None, errors=validation_errors)
|
return ExecutionResult(data=None, errors=validation_errors)
|
||||||
|
@ -373,12 +374,12 @@ class GraphQLView(View):
|
||||||
or connection.settings_dict.get("ATOMIC_MUTATIONS", False) is True
|
or connection.settings_dict.get("ATOMIC_MUTATIONS", False) is True
|
||||||
) and operation_ast.operation == OperationType.MUTATION:
|
) and operation_ast.operation == OperationType.MUTATION:
|
||||||
with transaction.atomic():
|
with transaction.atomic():
|
||||||
result = execute(*execute_args, **execute_options)
|
result = execute(schema, document, **execute_options)
|
||||||
if getattr(request, MUTATION_ERRORS_FLAG, False) is True:
|
if getattr(request, MUTATION_ERRORS_FLAG, False) is True:
|
||||||
transaction.set_rollback(True)
|
transaction.set_rollback(True)
|
||||||
return result
|
return result
|
||||||
|
|
||||||
return execute(*execute_args, **execute_options)
|
return execute(schema, document, **execute_options)
|
||||||
except Exception as e:
|
except Exception as e:
|
||||||
return ExecutionResult(errors=[e])
|
return ExecutionResult(errors=[e])
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue
Block a user