graphql-python/graphene-django
1
1
Fork 0
mirror of https://github.com/graphql-python/graphene-django.git synced 2024-11-24 10:34:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

Require operation_ast to be found by view handler

Browse Source
This commit is contained in:
Dan Sutich 2023-08-03 09:49:23 -04:00
parent 4b4259917f
commit 314c68d2d1
1 changed files with 17 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
graphene_django/views.py
View File

@ -12,6 +12,7 @@ from django.views.generic import View
from graphql import ExecutionResult, OperationType, execute, get_operation_ast, parse from graphql import ExecutionResult, OperationType, execute, get_operation_ast, parse
from graphql.error import GraphQLError from graphql.error import GraphQLError
from graphql.execution.middleware import MiddlewareManager from graphql.execution.middleware import MiddlewareManager
from graphql.language import OperationDefinitionNode
from graphql.validation import validate from graphql.validation import validate
from graphene import Schema from graphene import Schema
@ -300,13 +301,23 @@ class GraphQLView(View):
operation_ast = get_operation_ast(document, operation_name) operation_ast = get_operation_ast(document, operation_name)
op_error = None
if not operation_ast: if not operation_ast:
ops_count = len(
[
x
for x in document.definitions
if isinstance(x, OperationDefinitionNode)
]
)
if ops_count > 1:
op_error = (
"Must provide operation name if query contains multiple operations."
)
elif operation_name:
op_error = f"Unknown operation named '{operation_name}'."
else:
op_error = "Must provide a valid operation." op_error = "Must provide a valid operation."
elif operation_ast.operation == OperationType.SUBSCRIPTION:
op_error = "The 'subscription' operation is not supported."
if op_error:
return ExecutionResult(errors=[GraphQLError(op_error)]) return ExecutionResult(errors=[GraphQLError(op_error)])
if ( if (
@ -346,8 +357,7 @@ class GraphQLView(View):
if ( if (
graphene_settings.ATOMIC_MUTATIONS is True graphene_settings.ATOMIC_MUTATIONS is True
or connection.settings_dict.get("ATOMIC_MUTATIONS", False) is True or connection.settings_dict.get("ATOMIC_MUTATIONS", False) is True
and operation_ast.operation == OperationType.MUTATION ) and operation_ast.operation == OperationType.MUTATION:
):
with transaction.atomic(): with transaction.atomic():
result = execute(*execute_args, **execute_options) result = execute(*execute_args, **execute_options)
if getattr(request, MUTATION_ERRORS_FLAG, False) is True: if getattr(request, MUTATION_ERRORS_FLAG, False) is True: